Move adapters to http-body-util#56
Conversation
|
I think we should merge this @g2p probably worth a force push/fresh commit to trigger CI then we can review/merge? |
|
Sure, reworded something and force pushed. I think the CI runs require maintainer approval. |
LucioFranco
left a comment
LucioFranco
left a comment
There was a problem hiding this comment.
This looks mostly good. That said, can we also move http-body into its own folder?
|
Both crates have their own folders now. |
|
This looks good. It aligns with what is written in the hyper roadmap. My question now is, since this is a "breaking change" to |
|
imo we should merge this to master and start working towards 1.0 there. We can always make a |
|
Yea, lets create a |
|
@g2p can you resolve the conflicts and then we can merge this! thanks. |
Hyper works with all combinators removed, as would anything that depends on the initial 0.4 release. Removing methods from the trait is a breaking change, but it is possible to do the semver trick (release 0.5, then release 0.4.x with a dependency on the 0.5 trait) to not split the ecosystem. Addresses hyperium#52.
|
@LucioFranco done! |
|
Thanks!!! |
4 participants
Move utilities and combinators to a separate package
Hyper works with all combinators removed, as would anything that depends on the initial 0.4 release.
Removing methods from the trait is a breaking change, but it is possible to do the semver trick (release 0.5, then release 0.4.x with a dependency on the 0.5 trait) to not split the ecosystem and make the change painless.
Addresses #52.