-
Notifications
You must be signed in to change notification settings - Fork 562
feat(scraper): add two-stage tip/finalized scraper indexing #8193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
paulbalaji
wants to merge
7
commits into
main
Choose a base branch
from
pbio/scraper-two-stage-process-7fa5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a5d9ecc
Add two-stage tip/finalized scraper indexing
cursoragent b43f9c7
Address scraper PR feedback and clippy issues
paulbalaji e4dc8a3
Adjust tip cursor seed to include tip block on first sync
paulbalaji 02cf9cc
Harden cursor migration and pre-migration startup fallback
paulbalaji f41e5b2
scraper: fix legacy cursor write fallback
paulbalaji 8745868
run-locally: use exact metric labels for scraper invariants
paulbalaji 216ee60
run-locally: fix raw/tip and gas-payments invariant labels
paulbalaji File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
rust/main/agents/scraper/migration/src/m20260224_000007_add_cursor_type.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| use sea_orm_migration::prelude::*; | ||
|
|
||
| #[derive(DeriveMigrationName)] | ||
| pub struct Migration; | ||
|
|
||
| #[async_trait::async_trait] | ||
| impl MigrationTrait for Migration { | ||
| async fn up(&self, manager: &SchemaManager) -> Result<(), DbErr> { | ||
| let table = Cursor::Table.to_string(); | ||
| let cursor_type = Cursor::Stage.to_string(); | ||
| let domain = Cursor::Domain.to_string(); | ||
| let height = Cursor::Height.to_string(); | ||
| let index_name = "cursor_domain_type_height_idx"; | ||
|
|
||
| manager | ||
| .get_connection() | ||
| .execute_unprepared(&format!( | ||
| r#" | ||
| ALTER TABLE "{table}" | ||
| ADD COLUMN IF NOT EXISTS "{cursor_type}" TEXT NOT NULL DEFAULT 'finalized' | ||
| "# | ||
| )) | ||
| .await?; | ||
|
|
||
| manager | ||
| .get_connection() | ||
| .execute_unprepared(&format!( | ||
| r#" | ||
| CREATE INDEX IF NOT EXISTS "{index_name}" | ||
| ON "{table}" ("{domain}", "{cursor_type}", "{height}") | ||
| "# | ||
| )) | ||
| .await?; | ||
|
|
||
cursor[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| Ok(()) | ||
| } | ||
|
|
||
| async fn down(&self, manager: &SchemaManager) -> Result<(), DbErr> { | ||
| let table = Cursor::Table.to_string(); | ||
| let cursor_type = Cursor::Stage.to_string(); | ||
| let index_name = "cursor_domain_type_height_idx"; | ||
|
|
||
| manager | ||
| .get_connection() | ||
| .execute_unprepared(&format!(r#"DROP INDEX IF EXISTS "{index_name}""#)) | ||
| .await?; | ||
|
|
||
| manager | ||
| .get_connection() | ||
| .execute_unprepared(&format!( | ||
| r#"ALTER TABLE "{table}" DROP COLUMN IF EXISTS "{cursor_type}""# | ||
| )) | ||
| .await?; | ||
|
|
||
| Ok(()) | ||
| } | ||
| } | ||
|
|
||
| #[derive(Iden)] | ||
| enum Cursor { | ||
| Table, | ||
| Domain, | ||
| Height, | ||
| #[iden = "cursor_type"] | ||
| Stage, | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.