-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement local watcher #182
Closed
manoranjith
wants to merge
10
commits into
hyperledger-labs:dev
from
boschresearch:174-implement-local-watcher
Closed
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0ab1a9a
:sparkles: [channel] Define smaller interfaces for methods in adjudic…
1733588
:sparkles: [channel/adjudicator,watcher] Add interface defs for watcher
cab8bfa
:sparkles: [watcher/local] Implement local states pub-sub
e68a7fc
:sparkles: [watcher/local] Implement local adjudicator pub-sub
2fcc5e3
:sparkles: [watcher/local] Implement a channel registry
554b84a
:sparkles: [watcher/local] Implement start watching functionality
3e5b474
:sparkles: [watcher/local] Handle adj events without dispute
6373839
:sparkles: [watcher/local] Handle adj events with dispute
4544b58
:sparkles: [watcher/local] Relay progressed events to client
ba8bbb9
:sparkles: [watcher/local] Implement stop watching API
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
// Copyright 2021 - See NOTICE file for copyright holders. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
// Package watcher contains interface definitions for the watcher. | ||
// | ||
// These interfaces will be implemented by different watcher implementations. | ||
package watcher // import "perun.network/go-perun/watcher" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
// Copyright 2021 - See NOTICE file for copyright holders. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package watcher | ||
|
||
import ( | ||
"context" | ||
|
||
"perun.network/go-perun/channel" | ||
) | ||
|
||
type ( | ||
// Watcher is the interface used by client to interact with the Watcher. | ||
// | ||
// When a new channel is established, the client should register it with | ||
// the watcher by calling the StartWatching method. | ||
// | ||
// After that, it could publish each state on the StatesPub. If any state | ||
// is registered or progressed on the blockchain, the corresponding | ||
// adjudicator event will be relayed by the watcher on the AdjudicatorSub. | ||
// If the registered state is not the latest state (published to the | ||
// watcher) then, the watcher will automatically refute by registering the | ||
// latest state on the blockchain. | ||
// | ||
// Once a channel is closed, client can de-register the channel from the | ||
// watcher by calling the StopWatching API. This will close the | ||
// AdjudicatorSub and StatesSub. Client must not publish states after | ||
// this. | ||
Watcher interface { | ||
StartWatchingLedgerChannel(context.Context, channel.SignedState) (StatesPub, AdjudicatorSub, error) | ||
StartWatchingSubChannel(context.Context, channel.ID, channel.SignedState) (StatesPub, AdjudicatorSub, error) | ||
StopWatching(channel.ID) error | ||
ggwpez marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
// StatesPub is the interface used to send newer off-chain from the client | ||
// to the watcher. | ||
// | ||
// This is initialized when client starts watching for a given channel. | ||
// Client can send each state by calling the publish method. | ||
// | ||
// The publisher will be closed when client requests the watcher to stop | ||
// watching or when there is an error. After the client requests the | ||
// watcher to stop watching, Publish method must not be called. | ||
StatesPub interface { | ||
Publish(channel.Transaction) error | ||
ggwpez marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
// AdjudicatorSub is the interface used to relay the adjudicator events | ||
// from the watcher to the client. | ||
// | ||
// This is initialized when client starts watching for a given channel. | ||
// Client can receive the event via the channel returned by Next method. | ||
// | ||
// This channel will be closed when client requests the watcher to stop | ||
// watching or when there is an error. After the channel is closed, error | ||
// message can be read using the Err method. | ||
AdjudicatorSub interface { | ||
Next() <-chan channel.AdjudicatorEvent | ||
ggwpez marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Err() error | ||
} | ||
) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed. As adjudicator does not make subscriptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EventSubscriber
removed fromAdjudicator
, as it not used by the client anymore. (It is used only by theWatcher
andWatcher
uses theRegisterSubscriber
method. See PR #212.