Fix operator generator command excluding alloc field #7684
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixes the operator generator command so the genesis config alloc fields are included in the newly generated genesis file. This is a regression that was introduced recently in release 24.7.0.
The cause of the issue was the alloc field was removed from the ObjectNode argument when parsing the genesis file. I've modified the
GenesisReader.FromObjectNode
method so that the argument is no longer mutated. This is done by not removing the field from the ObjectNode and excluding it when normalising the keys adding a new normaliseKeys that takes a predicate.Also fixed the config files used for the operator subcommand test to have the ibft and qbft config in the correct place in the genesis file.
Fixed Issue(s)
fixes #7484
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests