Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix operator generator command excluding alloc field #7684

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

jframe
Copy link
Contributor

@jframe jframe commented Sep 27, 2024

PR description

Fixes the operator generator command so the genesis config alloc fields are included in the newly generated genesis file. This is a regression that was introduced recently in release 24.7.0.

The cause of the issue was the alloc field was removed from the ObjectNode argument when parsing the genesis file. I've modified the GenesisReader.FromObjectNode method so that the argument is no longer mutated. This is done by not removing the field from the ObjectNode and excluding it when normalising the keys adding a new normaliseKeys that takes a predicate.

Also fixed the config files used for the operator subcommand test to have the ibft and qbft config in the correct place in the genesis file.

Fixed Issue(s)

fixes #7484

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@jframe jframe marked this pull request as ready for review September 27, 2024 03:38
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jframe jframe merged commit 23ad2b5 into hyperledger:main Sep 30, 2024
43 checks passed
@jframe jframe deleted the operator_alloc_fix branch September 30, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QBFT] Besu Tesnet , Not getting token in alloc address
2 participants