Move EOF to the Osaka Fork #7719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shemnon
force-pushed
the
eof/osaka
branch
2 times, most recently
from
dbc1e2f
to
830b030
Compare
* Ensure Osaka activations are working * Remove CancunEOF and PragueEOF forks * Move EOF tools to default to Osaka Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
* Make PC in trace zeroed to start of code section 0 * Update extcall to consider precompiles warm * Add stack checking to CALLF operation Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
fab-10
reviewed
Oct 10, 2024
evm/src/main/java/org/hyperledger/besu/evm/tracing/StandardJsonTracer.java
Outdated
Show resolved
Hide resolved
| @@ -30,6 +31,9 @@ public class CallFOperation extends AbstractOperation { | |||
| /** The Call F success. */ | |||
| static final OperationResult callfSuccess = new OperationResult(5, null); | |||
|
|
|||
| static final OperationResult callfStackOverflow = | |||
There was a problem hiding this comment.
this seems unrelated to the move to Osaka, is it intended to be here?
There was a problem hiding this comment.
It's for this test that's landing soon - ethereum/execution-spec-tests#889
Signed-off-by: Danno Ferrin <[email protected]>
fab-10
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests