Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonar cloud build failure #7739

Merged
merged 11 commits into from
Oct 7, 2024
Merged

Sonar cloud build failure #7739

merged 11 commits into from
Oct 7, 2024

Conversation

jflo
Copy link
Contributor

@jflo jflo commented Oct 7, 2024

  • updates jacoco plugins to aggregate reports across sub-projects correctly.
  • excludes testutils subproject from analysis since it triggers a bug in sonar.
  • only runs block data generation for import/export tests if an existing database doesn't already exist.

@jflo
output stack
8080857 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
adds explicit dependencies for those gradle claimed
041987c 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
adds explicit dependencies for those gradle claimed
82aa102 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
adds explicit dependencies for those gradle claimed
a0c260a 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
wip
9d36a99 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
don't try to import to an existing db
2dad09c 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
deprecated task
d4258fb 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
testutil subproject hit a sonar bug
e5a5feb 
Signed-off-by: Justin Florentine <[email protected]>
@jflo
Merge branch 'main' into sonarCloudBuildFailure
499a889
garyschulte
garyschulte reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the verification metadata is unnecessary, otherwise lgtm

@jflo
revert updated deps
23573b3 
Signed-off-by: Justin Florentine <[email protected]>
@jflo jflo enabled auto-merge (squash) October 7, 2024 21:33
@jflo jflo requested a review from garyschulte October 7, 2024 21:33
@jflo jflo merged commit 3e7e4d8 into hyperledger:main Oct 7, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyschulte garyschulte garyschulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jflo @garyschulte