Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registration of RocksDB metrics categories #7879

Merged

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Nov 13, 2024

PR description

Fix a regression in the registration of RocksDB metrics categories introduced by #7825

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 fab-10 enabled auto-merge (squash) November 13, 2024 11:12
@fab-10 fab-10 force-pushed the fix-registration-of-rocksdb-metric-catrgories branch from 6044b19 to 983a4db Compare November 13, 2024 11:45
Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fab-10 fab-10 merged commit f156a17 into hyperledger:main Nov 14, 2024
43 checks passed
@fab-10 fab-10 deleted the fix-registration-of-rocksdb-metric-catrgories branch November 14, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants