Skip to content

Comments

devnet-6: 7702 changes for EXTCODE*#8169

Merged
siladu merged 14 commits intohyperledger:mainfrom
daniellehrner:feat/issue-8168/devnet-6-7702
Jan 31, 2025
Merged

devnet-6: 7702 changes for EXTCODE*#8169
siladu merged 14 commits intohyperledger:mainfrom
daniellehrner:feat/issue-8168/devnet-6-7702

Conversation

@daniellehrner
Copy link
Contributor

PR description

Change EXTCODE* oeprations to match spec for Pectra devnet-6

Fixed Issue(s)

fixes #8168

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@daniellehrner daniellehrner marked this pull request as ready for review January 31, 2025 10:25
fab-10 and others added 13 commits January 31, 2025 12:02
…8174)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
…er#8184)

This means you don't need to have the block already in the chain when you call debug_traceBlock with a block's RLP (you just need the parent).

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: jflo <justin+github@florentine.us>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
…ledger#8154)

Magic number "-32602" has been defined in the super interface, so reusing that constant value.

Signed-off-by: Andrew Cheng <andrewcheng1997@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Improve BLOCKHASH Short Circuit
Signed-off-by: Danno Ferrin <danno@numisight.com>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* add v for blob and pending tx

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* add v for blob and pending tx in tests

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* add v for blob tx in test

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Fix referenceTests bug with fallback EMPTY Address.
T8n support for excessBlobGas for both state tests and blockchain test. State tests should use the given excessBlobGas rather than computing from the parent header.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Brawn <nftdropped@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Fix hive tests for eip7685
* Pass correct empty request hash

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

---------

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* add acceptance tests to verify that code delegations are persisted even if the tx itself fails
* set node to use bonsai, set correct nonce for code delegation, make sure revert in contract has the 2 necessary items on the stack
* Hive test fix: only add account if authority nonce is valid (0)
---------

Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Co-authored-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Co-authored-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
…d after the fork (hyperledger#8211)

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
@daniellehrner daniellehrner force-pushed the feat/issue-8168/devnet-6-7702 branch from da8fdb7 to e3a3915 Compare January 31, 2025 11:03
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siladu siladu changed the title [DO NOT MERGE] devnet-6: 7702 changes for EXTCODE* devnet-6: 7702 changes for EXTCODE* Jan 31, 2025
@siladu siladu merged commit cf7d054 into hyperledger:main Jan 31, 2025
43 checks passed
pullurib pushed a commit to pullurib/besu that referenced this pull request Feb 6, 2025
change EXTCODE* operations to match spec for Pectra devnet-6

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

devnet-6: 7702 changes

10 participants