-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transaction hash for debug trace responses #8205
Conversation
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a small comment related to formatting json files in the tests.
I think it makes sens to keep existing format, unless you have a strong motivation around it.
"id":1, | ||
"result":{ | ||
"txHash":"0x2d8f594c7a98a9cb3d3a21d551f68e916e7ecd767971b061f2994b9a7426fba8", | ||
"result":{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe review the format to keep is as it is and in the differences only what changes. I see that almost the whole json file changed because of the change in the format, e.g
}, {
is replaced with
},
{
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I will not be able to avoid that because it will change with the indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair enough
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
@matkt think these might be legit failures (not flaky)
|
Signed-off-by: Karim Taam <[email protected]>
should be good now |
Signed-off-by: Karim Taam <[email protected]> Signed-off-by: Bhanu Pulluri <[email protected]>
PR description
This PR adds the transaction hash to the response of a debug trace API. This aligns the behavior with other clients and makes debugging easier.
for debug_traceBlock* the trx hash will be displayed and for debugTraceTransaction the tx hash will not be displayed
Fixed Issue(s)
fixes #8195
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests