Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Qbft to use its own QbftBlockHeader type #8244

Merged
merged 16 commits into from
Feb 7, 2025

Conversation

jframe
Copy link
Contributor

@jframe jframe commented Feb 4, 2025

Fixed Issue(s)

Adds a specific QBFT block header type, decoupling this type from the Ethereum block header so that QBFT can be used for other blocks without needing specific knowledge of the EVM or EL mainnet concepts, e.g. Could be used for a beacon block on an L2.

Changes

  • Introduced a qbft heaader type replacing the Ethereum header type
  • Created services/type interfaces in qbft core for operations that need to be performed on the block header
  • Added adaptors to the main qbft module to allow the use of Besu classes and services as qbft core types for use in the qbft core module

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@jframe jframe marked this pull request as ready for review February 6, 2025 03:12
@jframe jframe requested a review from usmansaleem February 6, 2025 03:13
Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple of nit-picks but can be ignored.

Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jframe jframe enabled auto-merge (squash) February 7, 2025 02:04
@jframe jframe merged commit a021fea into hyperledger:main Feb 7, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants