Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rpc gas cap default to 50M #8251

Merged
merged 3 commits into from
Feb 5, 2025
Merged

update rpc gas cap default to 50M #8251

merged 3 commits into from
Feb 5, 2025
+114 −30

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Feb 5, 2025

Signed-off-by: Sally MacFarlane [email protected]

PR description

Change rpc-gas-cap default from 0 (unlimited) to 50M

Fixed Issue(s)

Fixes #8175

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@macfarla
update rpc gas cap default to 50M
3924250 
Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla
changelog
48d26cd 
Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla
changelog
351d031 
Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla macfarla mentioned this pull request Feb 5, 2025
Merged
@macfarla macfarla added the doc-change-required Indicates an issue or PR that requires doc to be updated label Feb 5, 2025
siladu
siladu approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla merged commit 1e5fb00 into hyperledger:main Feb 5, 2025
43 checks passed
@macfarla macfarla deleted the rpc-gas-cap-default branch February 5, 2025 05:49
jframe pushed a commit to jframe/besu that referenced this pull request Feb 5, 2025
@macfarla @jframe
update rpc gas cap default to 50M (hyperledger#8251)
54a6415 
* update rpc gas cap default to 50M

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
pullurib pushed a commit to pullurib/besu that referenced this pull request Feb 6, 2025
@macfarla
update rpc gas cap default to 50M (hyperledger#8251)
6e83e67 
* update rpc gas cap default to 50M

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Bhanu Pulluri <[email protected]>
@macfarla macfarla removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siladu siladu siladu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The default rpc-gas-cap allows unlimited gas usage of eth_call
2 participants
@macfarla @siladu