Fix initEnclave in integration tests #500
Merged
+89
−168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: michael steiner <[email protected]>
Signed-off-by: michael steiner <[email protected]>
g2flyer
force-pushed
the
msteiner.initenclave-fix
branch
from
6c930ea to
e7c751d
Compare
bvavala
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
ecc_mock - ecc merge (#483) left various incompatibilities between integration test (e.g., peer wrapper) and sample network. As part of resolving this, i also simplified attestation parameter handling, added some more debug output and made
FPC_PATHthe sole shell variable we use, also in script (instead ofFPC_TOP_DIR)Which issue(s) this PR fixes:
Special notes for your reviewer:
Should work for all three scenarios
initEnclave. Complete integration test has to wait for merge of ERCC & sample-net fix/update #498 and completiong of Peer cli assist for client request/response processing #492 ...)Does this PR introduce a user-facing changes and/or breaks backward compatability?: