Implement lazy loading for chaincode lifecycle cache #5258
Closed
+375
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update introduces a lazy loading feature for the chaincode lifecycle cache, allowing chaincode information to be loaded on-demand rather than pre-initialized at startup. This can significantly improve peer startup times, especially in environments with many installed chaincodes. The feature can be enabled via the `core.yaml` configuration file. Additionally, tests have been added to verify the behavior of the cache with lazy loading enabled. - Updated `NewCache` function to accept a `lazyLoadEnabled` parameter. - Modified `InitializeLocalChaincodes` to skip pre-initialization when lazy loading is enabled. - Added new tests for lazy loading behavior in `cache_test.go`. - Created documentation for lazy loading in `peer_lifecycle_lazy_loading.md`. - Updated configuration example in `core.yaml` to include lazy loading option. Signed-off-by: dviejokfs <[email protected]>
Signed-off-by: dviejokfs <[email protected]>
This commit improves the lazy loading functionality by ensuring that chaincode information can be loaded on-demand when it is not pre-initialized. The changes include: - Added logic to check and load chaincode installation information if it is nil and lazy loading is enabled. - Updated configuration handling to support lazy loading via both `core.yaml` and environment variables. - Introduced a new test to verify the behavior of lazy loading when enabled through environment variables. Documentation has also been updated to reflect these changes. Signed-off-by: dviejokfs <[email protected]>
This commit refines the lazy loading mechanism for chaincode information by enhancing the logic that checks for existing local chaincode references. Key changes include: - Streamlined the process of finding the PackageID associated with a local chaincode definition. - Improved handling of cases where chaincode information is not yet available, allowing for more efficient lazy loading. - Added debug logging to provide better insights during the lazy loading process. These updates aim to optimize the performance and reliability of the chaincode lifecycle cache. Signed-off-by: dviejokfs <[email protected]>
This commit enhances the lazy loading mechanism for chaincode information by simplifying the conditions under which installation information is loaded. Key changes include: - Added a check for the PackageID before attempting to load installation info on-demand. - Streamlined the update process for local chaincode entries when installation info is retrieved. - Improved debug logging for better traceability during the lazy loading process. These modifications aim to optimize the efficiency and reliability of the chaincode lifecycle cache. Signed-off-by: dviejokfs <[email protected]>
Signed-off-by: dviejokfs <[email protected]>
Signed-off-by: dviejokfs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This update introduces a lazy loading feature for the chaincode lifecycle cache, allowing chaincode information to be loaded on-demand rather than pre-initialized at startup. This can significantly improve peer startup times, especially in environments with many installed chaincodes. The feature can be enabled via the
core.yamlconfiguration file. Additionally, tests have been added to verify the behavior of the cache with lazy loading enabled.Additional details
The implementation includes:
NewCachefunction to accept alazyLoadEnabledparameterInitializeLocalChaincodesto skip pre-initialization when lazy loading is enabledcache_test.gopeer_lifecycle_lazy_loading.mdcore.yamlto include lazy loading optionThis feature is particularly beneficial for peers with large numbers of installed chaincodes, as it eliminates the need to load all chaincode metadata during peer initialization, resulting in faster startup times.
Related issues
When there are a lot of chaincodes installed (10k+) peers take a long time to start since the cache is initialized. A new behaviour is needed to improve peer startup time when there are a lot of chaincodes installed.
Release Note
New Feature: Added lazy loading support for chaincode lifecycle cache to improve peer startup performance in environments with many installed chaincodes. This feature can be enabled via the
core.yamlconfiguration file.