Ensure that logging context is passed through for webhook deliveries #1703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 8, 2025 15:28
Signed-off-by: Dave Crighton <[email protected]>
Signed-off-by: Dave Crighton <[email protected]>
EnriqueL8
reviewed
Oct 13, 2025
| // Generate a bad-gateway error response - we always want to send something back, | ||
| // rather than just causing timeouts | ||
| log.L(wh.ctx).Errorf("Failed to invoke webhook: %s", gwErr) | ||
| log.L(ctx).Errorf("Failed to invoke webhook: %s on subscription %s", gwErr, sub.ID) |
There was a problem hiding this comment.
It's the CTX that should have the sub.ID in it - this is a transport layer that could be used in anything, it so happens that you want more logging as part of subscriptions
There was a problem hiding this comment.
I realize that his was already the case before in some order log lines, so worth validating that when we call buildPayload the ctx does have the subscription - which means the connID should be added now
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1703 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 342 342
Lines 30437 30439 +2
=======================================
+ Hits 30425 30427 +2
Misses 8 8
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR ensures that the parent request log context is used when constructing the log context for webhook deliveries. This makes it easier to correlate the root cause of webhook delivery failures with the rest of the log stream for a particular event.
Fixes # n/a
Types of changes
Please make sure to follow these points
Screenshots (If Applicable)
Other Information
Any message for the reviewer or kick off the discussion by explaining why you considered this particular solution, any alternatives etc.