Clippy updates

[marosset]

Fixes #549

WIP - I plan to move the clippy and fmt check out of dep_rust so we can a) run the in parallel, and b) not need to run them for each arch/hypervisor/target matrix. Right now I just want to test that we've caught all the clippy issues

[syntactically]

Thanks @marosset! This and the follow-up to move it to a different workflow and reduce CI time will be great to have :)

[syntactically]

This looks good overall. I have left inline a bunch of opinionated tips for defensive shell coding, which mostly don't matter here due to the fact that cargo features have a fairly limited character set. Feel free to ignore them, but I thought you might find them interesting/useful---unless otherwise noted, the style that I suggest generally deals nicely with pretty much any special characters in names of things by being careful to control quoting and word splitting. The one exception is NULs, which cannot be dealt with in bash unless you go to a great deal of effort to never read anything into a bash string (which is at heart a C string, and can't contain NULs).

[syntactically]

Again, feel free to ignore shell style nits

[marosset]

It looks like some more clippy issues got introduced by #696
I'll fix those us as part of this PR, then let's merge this (even with some bash/shell nits :P)

[marosset]

@syntactically - Can you review the new updates I pushed (50b08fe) which fixes some clippy issues in hyperlight_guest_bin introduced by a recent PR?
Thanks!

[ludfjig]

LGTM, ignoring any potential bash hygiene issues.

Btw, if mshv3 is a required feature, will mshv2 ever be checked? Since mshv3 "overwrites" mshv2

[syntactically]

Btw, if mshv3 is a required feature, will mshv2 ever be checked? Since mshv3 "overwrites" mshv2

I think we are planning to get rid of mshv2 very shortly.

[syntactically]

Thanks for catching these! Sorry, I guess our previous clippy configuration was missing this crate & I didn't think to run it manually. I have a bunch of comments on the safety notes; I can also do a commit to write them myself if you would like.

[marosset]

Thanks for catching these! Sorry, I guess our previous clippy configuration was missing this crate & I didn't think to run it manually. I have a bunch of comments on the safety notes; I can also do a commit to write them myself if you would like.

No problem. I think I addressed all the comments. PTAL

[syntactically]

These look much better, thanks! Commented on a few typos I saw but other than that looks good :)

[marosset]

These look much better, thanks! Commented on a few typos I saw but other than that looks good :)

/sigh, let me fix those