-
Notifications
You must be signed in to change notification settings - Fork 147
Guest tracing improvements to use tracing
crate
#844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
7f3e623
7084845
74bdb61
46ed93f
37f66c3
c30e6c7
a97d729
65f8dc0
5f8125a
588260a
99d35a7
22eb625
7329249
c426661
d527f19
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,7 +26,6 @@ spin = "0.10.0" | |
default = ["tracing"] | ||
fuzzing = ["dep:arbitrary"] | ||
trace_guest = [] | ||
unwind_guest = [] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What happened to this feature? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I merged it into the |
||
mem_profile = [] | ||
std = [] | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep it around, but as deprecated, shimming the new API? so that we don't break anyone who was already using this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think this is the way to go. But I don't think we'll ever use it again