Skip to content

Conversation

@nick1udwig
Copy link
Member

Problem

{A brief description of the problem, along with necessary context.}

Solution

{A brief description of how you solved the problem.}

Docs Update

Corresponding docs PR

Notes

{Any other information useful for reviewers.}

Copy link
Member Author

@nick1udwig nick1udwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bindings.rs is largely copied from hypermap.rs

I'm wondering if we can't remove all the dupe'd code and bring whatever unique functionality in from bindings.rs to hypermap.rs

E.g., we obviously need some constants: bring those in.

It looks like we need the ability to hit binding-cacher rather than hypermap-cacher: seems like we can just factor out a more general version of this function that takes an argument of what processid to hit, and then define a hypermap and a binding version that wraps that function, passing in the appropriate processid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants