-
Notifications
You must be signed in to change notification settings - Fork 5
hypermap binding cacher #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
nick1udwig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bindings.rs is largely copied from hypermap.rs
I'm wondering if we can't remove all the dupe'd code and bring whatever unique functionality in from bindings.rs to hypermap.rs
E.g., we obviously need some constants: bring those in.
It looks like we need the ability to hit binding-cacher rather than hypermap-cacher: seems like we can just factor out a more general version of this function that takes an argument of what processid to hit, and then define a hypermap and a binding version that wraps that function, passing in the appropriate processid
Problem
{A brief description of the problem, along with necessary context.}
Solution
{A brief description of how you solved the problem.}
Docs Update
Corresponding docs PR
Notes
{Any other information useful for reviewers.}