Avoid HTML characters to be encoded when unwrapping mention tags #6850
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6850 +/- ##
=======================================
Coverage 99.42% 99.42%
=======================================
Files 272 272
Lines 10451 10451
Branches 2510 2510
=======================================
Hits 10391 10391
Misses 60 60 ☔ View full report in Codecov by Sentry. |
acelaya
commented
Feb 26, 2025
Comment on lines
+100
to
+106
| { | ||
| text: `> Quote | ||
| Hello @jane.doe.`, | ||
| authority: 'example.com', | ||
| textWithTags: `> Quote | ||
| Hello ${mentionTag('jane.doe', 'example.com')}.`, | ||
| }, |
There was a problem hiding this comment.
This test does not pass in main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6849
Make sure HTML special characters in the annotation text are not HTML-encoded as a side effect of unwrapping mention tags.
This PR is motivated by #6849, where the ability to quote text via
>is broken, as it was being converted to<