Skip to content

Fix build issues #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
victorapm wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix build issues #1463

victorapm wants to merge 8 commits into from

Conversation

@victorapm
Copy link
Contributor

@victorapm victorapm commented Jan 24, 2026 •
edited
Loading

Fixes build issues:

  1. GPU + SuperLU_dist build:
src/parcsr_ls/par_amg_setup.c(3158): error: a value of type "void *" cannot be assigned to an entity of type "HYPRE_Solver" (aka "hypre_Solver_struct *")
        ((amg_data)->dslu_solver) = dslu_solver;
  1. rocm 7.2 build
  2. Externally provided rocThrust, see spack CI: https://gitlab.spack.io/spack/spack-packages/-/jobs/19969598#L773
  3. Externally provided rocPRIM, see spack CI: https://gitlab.spack.io/spack/spack-packages/-/jobs/19974857#L607
  4. Fix portability issue introduced in Link order used in configure #1402. See PETSc report: https://gitlab.com/petsc/petsc/-/merge_requests/8978
  5. ffs usage in MinGW

@victorapm victorapm requested a review from rfalgout January 24, 2026 02:38
@victorapm victorapm added the Run CI Label to trigger CI jobs label Jan 24, 2026
@victorapm
Copy link
Contributor Author

victorapm commented Jan 24, 2026

@rfalgout, It seems we are not testing the build with superlu_dist and cuda/rocm enabled. Perhaps we could put it in machine-tux-spack

@prj-
Copy link
Contributor

prj- commented Jan 26, 2026

Would you consider releasing version 3.1.1 with these fixes?

@victorapm victorapm mentioned this pull request Jan 26, 2026
Merged
@victorapm victorapm changed the title Fix build with GPU + SuperLU_Dist support Fix build issues Jan 27, 2026
@victorapm victorapm mentioned this pull request Jan 27, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rfalgout rfalgout Awaiting requested review from rfalgout

Assignees

No one assigned

Labels

Run CI Label to trigger CI jobs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@victorapm @prj- @brechtsanders