-
-
Notifications
You must be signed in to change notification settings - Fork 125
core: add a greetd login backend #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This is my setup on nixos: https://github.com/PaideiaDilemma/dotnix/blob/main/host/sessions.nix |
|
I personally use greetd autologin and have hyprlock as an exec-once in my hl config. I would use a proper greeter but the transition isn't seamless. That being said, I'm not opposed to this change. |
3efcb66 to
87000be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe consider adding pointer support first so that people can click on session entries
Yeah there is always a gpu reset when starting the actual session. |
a monitor modeset, not a gpu reset... |
b9d3295 to
0a91ad5
Compare
I have the Ryzen 5800U iGPU. About the same generation, but launching is pretty choppy. I'm curious how KDE/Gnome handle this with SDDM/GDM. |
|
Current status of this draft ? @vaxerski edit: sorry for the ping. Thought this was years ago . |
|
not my draft? |
|
Been running this for the past week or so and it is so far working great on my end! Would it be possible to add an option to preselect a session type, or even force a particular one? Didn't find such an option being there yet in the diff. I don't really want to show the session picker (as I only have a hl session) but at the moment it chooses the And maybe we'd also want to disable the arrow keys for switching sessions if the session picker is not shown, so people don't accidentally change the session without noticing. |
eb008ea to
e9644ef
Compare
Yep. Right now you can tell hyprlock where to search for wayland sessions (as .desktop files), but you can also manually specify a session in the config with
Good point! The session is now fixed at 0, or the default session if it's configured, when there is no session-picker widget in the config. Next I will add click support and text align for the session-picker widget. |
|
Thanks for adding the default session option, can confirm that it works as expected. Here's a couple of minor issues I noticed while testing my own config, but nothing breaking or really important:
What also would be nice would be a proper way to test a greetd configuration, without having to go into a greetd session. I did my testing by running
While I myself don't really plan on using a session picker, here's some ideas anyways. What I like about the session picker as it is currently implemented is how convenient it is. You can just add one widget to your config, tweak a couple of colors and have a nice looking and functional setup. So I'd suggest keeping it for that reason. For users which might want something different or more customizable, we could do two things, 1. adding a new substitution variable which shows the currently selected session name, and 2. some kind of special keyword you could set an |
|
It works great! The only issue I found is that I'm unable to use the fingerprint when launched with Right now, I have installed this version using nix. |
|
@VirtCode @MalpenZibo Extra great feedback thanks!!! I will address it soonish. |
|
Sadly fingerprint won't work with greetd. Thant being said, it's probably best. When you log in initially you shouldn't be able to use biometrics. That opens up a bunch of potential attacks. |
|
Just gave this a try and I just wanted to say that you've been doing great work @PaideiaDilemma ! |
e9644ef to
4dc9129
Compare
Just to add my 2c since |
|
That has absolutely nothing to do with this PR and also no, even if you use |
|
Update on the PR: Rebased and we now have click support for the session-picker and I think I fixed the crash @VirtCode mentioned. |
I agree with you and just wanted to expand your argument but I've skipped important parts since they were obvious to me. I'm fully aware of how GrapheneOS does it, it was just a mental shortcut you know. :D Anyway thanks for your work! |
|
I would like to test your fork, but since I am new to NixOS and Hyprland, I don't know how to do it. I currently use SDDM and Hyprlock. I saw that you did something like: # for greetd login via hyprlock
hyprlock-greetd = {
url = "github:PaideiaDilemma/hyprlock?ref=greetdLogin";
inputs.nixpkgs.follows = "nixpkgs";
inputs.hyprlang.follows = "hyprland";
inputs.hyprutils.follows = "hyprutils";
};What other settings should I use? Thanks in advance. Edit: which branch should I look at? cause it seems like in the last commit of |
This MR allows hyprlock to function as a greeter.
Hyprlock would be usable as a login frontend for greetd as well as a wayland lockscreen application.
Some details:
Currently only support a single static user.
TODO:
Related issue: #564