core: Asahi core dump #839 #895
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Apple silicon, rendering is done on a separate node, so do not limit selection of the render node to the display device in case the display device does not have rendering.
Comment on lines
98
to
120
| for (int i = 0; i < n; ++i) { | ||
| drmDevice* dev = devices[i]; | ||
| if (device && !drmDevicesEqual(device, dev)) { | ||
| continue; | ||
| } | ||
| if (!(dev->available_nodes & (1 << DRM_NODE_RENDER))) | ||
| continue; | ||
|
|
||
| render_node = strdup(dev->nodes[DRM_NODE_RENDER]); | ||
| break; | ||
| } | ||
|
|
||
| /* Select any available render node in case the device does not have one */ | ||
| if (!render_node) { | ||
| for (int i = 0; i < n; ++i) { | ||
| drmDevice* dev = devices[i]; | ||
| if (device && drmDevicesEqual(device, dev)) | ||
| continue; // skip the one we already tried | ||
| if (dev->available_nodes & (1 << DRM_NODE_RENDER)) { | ||
| render_node = strdup(dev->nodes[DRM_NODE_RENDER]); | ||
| break; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
???? That is just trying the same code once again
Collaborator
There was a problem hiding this comment.
Oh ok so you skip the first drmDevicesEqual xD
I think the problem is how we handle https://wayland.app/protocols/wayland-protocols/432#zwp_linux_dmabuf_feedback_v1:event:tranche_target_device. (Probably)
It would be better to fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Apple silicon, rendering is done on a separate node, so do not limit selection of the render node to the display device in case the display device does not have rendering.