-
-
Notifications
You must be signed in to change notification settings - Fork 35
Add config #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config #41
Conversation
|
I currently made it, so that when passing --temperature or --gamma to the command, this will override the current active profile's temperature/gamma. On the next scheduled profile it would however then use the profile's temperature/gamma. Maybe this functionality has to be discussed |
|
For thread safety, i have just added a lock guard in the schedule function. To my understanding this should now be thread-safe. Let me know if it isn't or if I should adopt something different |
|
it's not enough unfortunately. |
Oh, my bad. Didn't understand that the issue lies in the wl_display_dispatch. Will fix that ASAP |
vaxerski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice, just a minor style nit.
|
also run clang-format if you havent |
already did |
vaxerski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just needs a wiki mr
|
I'd also like to suggest we now bump the version to 1.0, as this, in my opinion marks a big milestone in the usability of hyprsunset |
we don't do 1.x |
oops my bad, then 0.3 right |
|
ye |
This PR aims to add support for a hyprsunset.conf file.
The user can set different profiles in his config, which will then be applied automatically at the provided time.
I have implemented it in a way, so that you could introduce as many profiles as you like. An alternative would be to provide just a day and night profile.