Skip to content

feat: add sunrise/sunset scheduling support #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BaigHack3rss wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add sunrise/sunset scheduling support #72

BaigHack3rss wants to merge 1 commit into from
+456 −1

Conversation

@BaigHack3rss
Copy link

@BaigHack3rss BaigHack3rss commented Nov 29, 2025 •
edited
Loading

Updates

New Helper

  • NSunCalc: Added a helper that computes sunrise and sunset using the NOAA formulas.

Config Enhancements

  • ConfigManager extended with:
    • latitude and longitude options
    • Support for SUN-based profile times (sunrise/sunset–driven scheduling)

Behavior Changes

  • Emit a warning when two profiles share the same clock slot.
  • Skip profiles when required sun events (sunrise/sunset) are missing.

Testing Notes

  • Verified locally.
  • Original features continue to function.
  • Sunset computation works as expected.
  • Sunrise computation works as expected.
  • Automatic updating of sunrise/sunset times functions correctly.
    • The precise update interval is uncertain: likely on restart (possibly daily, but unverified).

@BaigHack3rss
feat: add sunrise/sunset scheduling support
d0da08a 
- add NSunCalc helper that computes sunrise/sunset with NOAA formulas
- extend ConfigManager with latitude/longitude options and SUN-based profile times
- warn when two profiles share a clock slot and skip profiles with missing sun events

Tests: Tested locally; Original features work, sunset works according to
my knowledge, sunrise not tested (2:00 am right now)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@BaigHack3rss