Skip to content

chore(platform): bump lima version #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jezekra1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(platform): bump lima version #1721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions apps/agentstack-cli/src/agentstack_cli/commands/platform/lima_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ async def create_vm(self):
template_file.write(
yaml.dump(
{
"ssh": {"overVsock": False},
"images": [
{
"location": "https://cloud-images.ubuntu.com/releases/noble/release/ubuntu-24.04-server-cloudimg-amd64.img",
Expand Down Expand Up @@ -139,20 +140,14 @@ async def create_vm(self):
template_file.flush()
template_file.close()
await run_command(
[
self.limactl_exe,
"--tty=false",
"start",
str(template_file.name),
f"--name={self.vm_name}",
],
[self.limactl_exe, "--tty=false", "start", str(template_file.name), f"--name={self.vm_name}"],
"Creating a Lima VM",
env={"LIMA_HOME": str(Configuration().lima_home)},
cwd="/",
)
elif current_status != "running":
await run_command(
[self.limactl_exe, "--tty=false", "start", self.vm_name],
[self.limactl_exe, "--tty=false", "start", "--set", ".ssh.overVsock=false", self.vm_name],
"Starting up",
env={"LIMA_HOME": str(Configuration().lima_home)},
cwd="/",
Expand Down
58 changes: 11 additions & 47 deletions mise.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,51 +1,31 @@
[[tools."asdf:CrouchingMuppet/asdf-lima"]]
version = "1.2.1"
version = "2.0.2"
backend = "asdf:CrouchingMuppet/asdf-lima"

[[tools.fd]]
version = "10.3.0"
backend = "aqua:sharkdp/fd"

[tools.fd.platforms.macos-arm64]
checksum = "sha256:0570263812089120bc2a5d84f9e65cd0c25e4a4d724c80075c357239c74ae904"
size = 1337349
url = "https://github.com/sharkdp/fd/releases/download/v10.3.0/fd-v10.3.0-aarch64-apple-darwin.tar.gz"
"platforms.macos-arm64" = { checksum = "sha256:0570263812089120bc2a5d84f9e65cd0c25e4a4d724c80075c357239c74ae904", url = "https://github.com/sharkdp/fd/releases/download/v10.3.0/fd-v10.3.0-aarch64-apple-darwin.tar.gz"}
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The reformatting of the lock file has removed the size attribute for several tool artifacts (e.g., for fd, gum, helm, etc.). While the checksum ensures integrity, the size attribute provides a useful secondary check against issues like truncated downloads. Removing this check weakens the overall verification process. If the mise tool still supports this attribute, it should be retained for better robustness.


[[tools.gum]]
version = "0.17.0"
backend = "aqua:charmbracelet/gum"

[tools.gum.platforms.macos-arm64]
checksum = "sha256:e2a4b8596efa05821d8c58d0c1afbcd7ad1699ba69c689cc3ff23a4a99c8b237"
size = 4395909
url = "https://github.com/charmbracelet/gum/releases/download/v0.17.0/gum_0.17.0_Darwin_arm64.tar.gz"
"platforms.macos-arm64" = { checksum = "sha256:e2a4b8596efa05821d8c58d0c1afbcd7ad1699ba69c689cc3ff23a4a99c8b237", url = "https://github.com/charmbracelet/gum/releases/download/v0.17.0/gum_0.17.0_Darwin_arm64.tar.gz"}

[[tools.helm]]
version = "3.19.0"
backend = "aqua:helm/helm"

[tools.helm.platforms.macos-arm64]
checksum = "sha256:31513e1193da4eb4ae042eb5f98ef9aca7890cfa136f4707c8d4f70e2115bef6"
size = 17058141
url = "https://get.helm.sh/helm-v3.19.0-darwin-arm64.tar.gz"
"platforms.macos-arm64" = { checksum = "sha256:31513e1193da4eb4ae042eb5f98ef9aca7890cfa136f4707c8d4f70e2115bef6", url = "https://get.helm.sh/helm-v3.19.0-darwin-arm64.tar.gz"}

[[tools.kubeconform]]
version = "0.7.0"
backend = "aqua:yannh/kubeconform"

[tools.kubeconform.platforms.macos-arm64]
checksum = "sha256:b5d32b2cb77f9c781c976b20a85e2d0bc8f9184d5d1cfe665a2f31a19f99eeb9"
size = 7031569
url = "https://github.com/yannh/kubeconform/releases/download/v0.7.0/kubeconform-darwin-arm64.tar.gz"
"platforms.macos-arm64" = { checksum = "sha256:b5d32b2cb77f9c781c976b20a85e2d0bc8f9184d5d1cfe665a2f31a19f99eeb9", url = "https://github.com/yannh/kubeconform/releases/download/v0.7.0/kubeconform-darwin-arm64.tar.gz"}

[[tools.node]]
version = "22.19.0"
backend = "core:node"

[tools.node.platforms.macos-arm64]
checksum = "sha256:c59006db713c770d6ec63ae16cb3edc11f49ee093b5c415d667bb4f436c6526d"
size = 47739366
url = "https://nodejs.org/dist/v22.19.0/node-v22.19.0-darwin-arm64.tar.gz"
"platforms.macos-arm64" = { checksum = "sha256:c59006db713c770d6ec63ae16cb3edc11f49ee093b5c415d667bb4f436c6526d", url = "https://nodejs.org/dist/v22.19.0/node-v22.19.0-darwin-arm64.tar.gz"}

[[tools."pipx:toml-cli"]]
version = "0.8.2"
Expand All @@ -54,40 +34,24 @@ backend = "pipx:toml-cli"
[[tools.pnpm]]
version = "10.15.1"
backend = "aqua:pnpm/pnpm"

[tools.pnpm.platforms.macos-arm64]
checksum = "sha256:b64bd9e75d92934251bd0b890d3d4d1073e85d71bf39227ff6a6408d27c3106d"
size = 62649648
url = "https://github.com/pnpm/pnpm/releases/download/v10.15.1/pnpm-macos-arm64"
"platforms.macos-arm64" = { checksum = "sha256:b64bd9e75d92934251bd0b890d3d4d1073e85d71bf39227ff6a6408d27c3106d", url = "https://github.com/pnpm/pnpm/releases/download/v10.15.1/pnpm-macos-arm64"}

[[tools."ubi:google/addlicense"]]
version = "1.2.0"
backend = "ubi:google/addlicense"

[tools."ubi:google/addlicense".platforms.macos-arm64-addlicense]
checksum = "blake3:29c4b12b602b33cf8b88b2f947741bdbd60516afd72d9585abc95912fbeca47a"
"platforms.macos-arm64-addlicense" = { checksum = "blake3:29c4b12b602b33cf8b88b2f947741bdbd60516afd72d9585abc95912fbeca47a"}

[[tools."ubi:telepresenceio/telepresence"]]
version = "2.24.1"
backend = "ubi:telepresenceio/telepresence"

[tools."ubi:telepresenceio/telepresence".platforms.macos-arm64-telepresence]
checksum = "blake3:1d8fc5495ba38b306e2b7b01da21446312eb6fe2111c83d520a56fa5a0b69cb5"
"platforms.macos-arm64-telepresence" = { checksum = "blake3:1d8fc5495ba38b306e2b7b01da21446312eb6fe2111c83d520a56fa5a0b69cb5"}

[[tools.uv]]
version = "0.9.5"
backend = "aqua:astral-sh/uv"

[tools.uv.platforms.macos-arm64]
checksum = "sha256:dc098ff224d78ed418e121fd374f655949d2c7031a70f6f6604eaf016a130433"
size = 18341942
url = "https://github.com/astral-sh/uv/releases/download/0.9.5/uv-aarch64-apple-darwin.tar.gz"
"platforms.macos-arm64" = { checksum = "sha256:dc098ff224d78ed418e121fd374f655949d2c7031a70f6f6604eaf016a130433", url = "https://github.com/astral-sh/uv/releases/download/0.9.5/uv-aarch64-apple-darwin.tar.gz"}

[[tools.yq]]
version = "4.47.2"
backend = "aqua:mikefarah/yq"

[tools.yq.platforms.macos-arm64]
checksum = "sha256:4ccc7f2f5f6f37804d70ad211a287b1b589f67024ecb77586c77106030424b9f"
size = 10980754
url = "https://github.com/mikefarah/yq/releases/download/v4.47.2/yq_darwin_arm64"
"platforms.macos-arm64" = { checksum = "sha256:4ccc7f2f5f6f37804d70ad211a287b1b589f67024ecb77586c77106030424b9f", url = "https://github.com/mikefarah/yq/releases/download/v4.47.2/yq_darwin_arm64"}
2 changes: 1 addition & 1 deletion mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tools]
# runtime
"asdf:CrouchingMuppet/asdf-lima" = "1.2.1" # using lima from asdf since the aqua one fails to install in CI
"asdf:CrouchingMuppet/asdf-lima" = "2.0.2" # using lima from asdf since the aqua one fails to install in CI
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Bumping asdf-lima from 1.2.1 to 2.0.2 is a major version upgrade. Major version updates often include breaking changes to command-line arguments, configuration formats, or output formats. Given that apps/agentstack-cli/src/agentstack_cli/commands/platform/lima_driver.py relies on limactl's specific behavior (e.g., for list --format=json), this change introduces a significant risk of breaking the platform functionality. Without corresponding updates to the driver, this upgrade is likely to cause runtime failures. This change should either be reverted, or the necessary updates to lima_driver.py should be included in this pull request to ensure compatibility.


# Python
uv = "0.9.5"
Expand Down
Loading