-
Notifications
You must be signed in to change notification settings - Fork 136
[DRAFT] feat(ui): move API to SDK #1737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Petr Bulánek <[email protected]>
Signed-off-by: Petr Bulánek <[email protected]>
Signed-off-by: Petr Bulánek <[email protected]>
Signed-off-by: Petr Bulánek <[email protected]>
Signed-off-by: Petr Bulánek <[email protected]>
Signed-off-by: Petr Bulánek <[email protected]>
Signed-off-by: Petr Bulánek <[email protected]>
Summary of ChangesHello @PetrBulanek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a major architectural overhaul by migrating the existing API client and A2A extensions into a newly structured SDK. The primary goal is to enhance modularity, type safety, and error handling across the platform. The changes involve a comprehensive reorganization of code, the introduction of a more robust API interaction pattern, and a full update of the UI application to seamlessly adopt these new SDK capabilities. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant and well-executed refactoring, moving the API client logic and type definitions into a dedicated agentstack-sdk-ts package. This greatly improves the overall architecture by creating a clear separation of concerns, enhancing type safety, and establishing a more robust and reusable API client. The new structure with a core API builder, modular endpoints, and structured error handling is a major step forward.
My review has identified a recurring critical issue across several new Zod schema definitions where z.enum() is used incorrectly with TypeScript enums, which will cause runtime errors. I've left specific comments with suggestions to use z.nativeEnum() instead. I also found a minor opportunity to improve the robustness of a URL-building utility function.
Once these issues are addressed, this will be an excellent contribution to the codebase.
apps/agentstack-sdk-ts/src/client/a2a/extensions/services/mcp/schemas.ts
Show resolved
Hide resolved
apps/agentstack-sdk-ts/src/client/a2a/extensions/ui/agent-detail/schemas.ts
Show resolved
Hide resolved
| Object.entries(data).forEach(([key, value]) => { | ||
| if (value != null) { | ||
| searchParams.append(key, String(value)); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation for building query parameters from a data object converts array values to a single comma-separated string. This might not be what the server expects for multi-valued parameters. A more standard and robust approach is to append each item of the array separately to the URLSearchParams. This will generate query parameters like key=value1&key=value2 instead of key=value1,value2.
| Object.entries(data).forEach(([key, value]) => { | |
| if (value != null) { | |
| searchParams.append(key, String(value)); | |
| } | |
| }); | |
| Object.entries(data).forEach(([key, value]) => { | |
| if (value != null) { | |
| if (Array.isArray(value)) { | |
| value.forEach((item) => searchParams.append(key, String(item))); | |
| } else { | |
| searchParams.append(key, String(value)); | |
| } | |
| } | |
| }); |
Signed-off-by: Petr Bulánek <[email protected]>
Signed-off-by: Petr Bulánek <[email protected]>
Signed-off-by: Petr Bulánek <[email protected]>
| import type { ApiMethod } from './types'; | ||
|
|
||
| export function buildRequestUrl({ baseUrl, path, query }: { baseUrl: string; path: string; query?: ApiQueryParams }) { | ||
| const url = `${baseUrl.replace(/\/+$/, '')}${path}`; |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
regular expression
library input
Signed-off-by: Petr Bulánek <[email protected]>
Signed-off-by: Petr Bulánek <[email protected]>
Signed-off-by: Petr Bulánek <[email protected]>
Signed-off-by: Petr Bulánek <[email protected]>
Signed-off-by: Petr Bulánek <[email protected]>
Summary
Linked Issues
Closes: #1692
Documentation
If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.