-
Notifications
You must be signed in to change notification settings - Fork 137
feat(sdk): add extension for user approval #1775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @pilartomas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the AgentStack SDK by integrating a dedicated Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new generic user approval extension, which is a great addition for interactive agent workflows. It also deprecates the older, more specific ToolCallRequest and ToolCallExtensionServer in favor of this new mechanism. The implementation of the new approval extension is well-structured. I've added a few suggestions to improve code clarity and maintainability.
apps/agentstack-sdk-py/src/agentstack_sdk/a2a/extensions/interactions/__init__.py
Show resolved
Hide resolved
apps/agentstack-sdk-py/src/agentstack_sdk/a2a/extensions/interactions/approval.py
Outdated
Show resolved
Hide resolved
apps/agentstack-sdk-py/src/agentstack_sdk/a2a/extensions/interactions/approval.py
Outdated
Show resolved
Hide resolved
1b17adf to
a23d9a6
Compare
Signed-off-by: Tomas Pilar <[email protected]>
a23d9a6 to
5962121
Compare
Signed-off-by: Tomas Pilar <[email protected]>
5d56f82 to
1af57f6
Compare
Signed-off-by: Tomas Pilar <[email protected]>
Signed-off-by: Tomas Pilar <[email protected]>
Signed-off-by: Tomas Pilar <[email protected]>
Signed-off-by: Tomas Pilar <[email protected]>
Signed-off-by: Tomas Pilar <[email protected]>
Signed-off-by: Tomas Pilar [email protected]
Summary
Linked Issues
closes #1762
Documentation
If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.