-
Notifications
You must be signed in to change notification settings - Fork 137
fix(cli): log stream shows error on finish #1780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Radek Ježek <[email protected]>
Summary of ChangesHello @jezekra1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue in the CLI where the log stream would erroneously report an error upon completion. The change introduces a more precise way to handle different types of log messages, specifically by recognizing and gracefully terminating when a Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes an error that occurs at the end of a log stream by handling the [DONE] event. The implementation is changed from an if/elif block to a match/case statement, which improves readability. I've added a suggestion to make the log printing more robust for various message formats by improving the pattern matching logic.
| match line: | ||
| case {"stream": "stderr"}: | ||
| (out_console or err_console).print(decode(line["message"])) | ||
| case {"stream": "stdout"}: | ||
| (out_console or console).print(decode(line["message"])) | ||
| case {"event": "[DONE]"}: | ||
| return | ||
| case _: | ||
| (out_console or console).print(line) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new match statement is a good improvement for readability. However, the catch-all case _: might not provide the best user experience for unhandled log messages as it prints the entire line object. If a log entry from an unknown stream type contains a message key, it would be better to extract and print that message, similar to how stdout and stderr are handled.
I suggest expanding the pattern matching to handle any dictionary with a message key as a fallback, and also to use variable binding for cleaner access to the message.
| match line: | |
| case {"stream": "stderr"}: | |
| (out_console or err_console).print(decode(line["message"])) | |
| case {"stream": "stdout"}: | |
| (out_console or console).print(decode(line["message"])) | |
| case {"event": "[DONE]"}: | |
| return | |
| case _: | |
| (out_console or console).print(line) | |
| match line: | |
| case {"stream": "stderr", "message": message}: | |
| (out_console or err_console).print(decode(message)) | |
| case {"stream": "stdout", "message": message}: | |
| (out_console or console).print(decode(message)) | |
| case {"event": "[DONE]"}: | |
| return | |
| case {"message": message}: | |
| (out_console or console).print(decode(message)) | |
| case _: | |
| (out_console or console).print(line) |
Summary
Linked Issues
Documentation
If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.