Skip to content

Conversation

@JanPokorny
Copy link
Collaborator

Signed-off-by: Jan Pokorný [email protected]

Summary

Linked Issues

Documentation

  • No Docs Needed:

If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 8, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @JanPokorny, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a technical debt cleanup by updating the syntax of Mise task definitions. It systematically replaces older, deprecated methods for handling task options and arguments with the recommended usage block and corresponding variable access patterns. This modernization effort is crucial for maintaining the project's build and development workflows, ensuring they remain compatible with the Mise task runner and adhere to its evolving API standards.

Highlights

  • Mise Syntax Update: The pull request migrates deprecated Mise task parameter syntax (e.g., {{option(...)}}, {{arg(...)}}) to the modern usage = '...' block and ${usage_...} variable interpolation.
  • Improved Task Definitions: Task definitions across various tasks.toml files have been updated to use the new usage syntax for defining flags and arguments, enhancing clarity and consistency.
  • Compatibility and Maintenance: This chore ensures compatibility with newer Mise versions and aligns the project's task configurations with current best practices for the tool.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the mise task syntax from the deprecated {{...}} format to the new usage and ${usage_...} format. The changes are mostly correct and improve consistency. However, I found a critical bug where a variable update was missed in one of the scripts, which breaks the functionality of a command-line flag. I also found a couple of minor issues with redundant variable definitions. Please see my detailed comments for fixes.

@JanPokorny JanPokorny force-pushed the janpokorny/chore-ci-update-deprecated-mise-syntax branch 2 times, most recently from fa87089 to 4fcd342 Compare January 8, 2026 11:02
@JanPokorny JanPokorny changed the title chore(ci): update deprecated Mise syntax chore(ci): update Mise Jan 8, 2026
@JanPokorny JanPokorny force-pushed the janpokorny/chore-ci-update-deprecated-mise-syntax branch 4 times, most recently from 3e27e5c to 9442eda Compare January 8, 2026 15:22
@JanPokorny JanPokorny force-pushed the janpokorny/chore-ci-update-deprecated-mise-syntax branch from 9442eda to ccdeafe Compare January 8, 2026 15:42
@JanPokorny JanPokorny merged commit b6ac710 into main Jan 8, 2026
12 checks passed
@JanPokorny JanPokorny deleted the janpokorny/chore-ci-update-deprecated-mise-syntax branch January 8, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants