-
Notifications
You must be signed in to change notification settings - Fork 137
chore(ci): update Mise #1782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): update Mise #1782
Conversation
Summary of ChangesHello @JanPokorny, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a technical debt cleanup by updating the syntax of Mise task definitions. It systematically replaces older, deprecated methods for handling task options and arguments with the recommended Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the mise task syntax from the deprecated {{...}} format to the new usage and ${usage_...} format. The changes are mostly correct and improve consistency. However, I found a critical bug where a variable update was missed in one of the scripts, which breaks the functionality of a command-line flag. I also found a couple of minor issues with redundant variable definitions. Please see my detailed comments for fixes.
fa87089 to
4fcd342
Compare
3e27e5c to
9442eda
Compare
Signed-off-by: Jan Pokorný <[email protected]>
9442eda to
ccdeafe
Compare
Signed-off-by: Jan Pokorný [email protected]
Summary
Linked Issues
Documentation
If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.