-
Notifications
You must be signed in to change notification settings - Fork 138
chore(dev): simplify dev mode, add agent instructions #1784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @jezekra1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on simplifying and clarifying the development and testing experience within the AgentStack monorepo. It introduces a detailed set of guidelines to onboard developers and provides a clearer understanding of the project's architecture and workflows. Concurrently, it refines the development environment setup by consolidating test-related configurations and standardizing the kubeconfig usage, aiming to reduce complexity and improve developer efficiency. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request simplifies the development workflow by unifying the development and testing environments, which is a great improvement for developer experience. The changes are consistently applied across documentation, task configurations, and test setup. The addition of the new agent-guidelines.md file is also a valuable contribution, providing clear instructions for the agent. I have a couple of minor suggestions for the new markdown file to enhance its clarity.
| ## 7. General Best Practices | ||
| - **Commands**: Construct commands relative to the project root or verify `cwd` before running. | ||
| - **Verification**: If unsure about environment state, check `/healthcheck` or ask the user. | ||
| - **Docs**: You can read and modify documentation in the `docs/development` folder to get more information No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence appears to be incomplete and has a trailing space. It would be clearer if it ended with a period.
| - **Docs**: You can read and modify documentation in the `docs/development` folder to get more information | |
| - **Docs**: You can read and modify documentation in the `docs/development` folder to get more information. |
15c51f1 to
928041e
Compare
Signed-off-by: Radek Ježek <[email protected]>
928041e to
c43144e
Compare
Summary
Linked Issues
Documentation
If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.