Skip to content

Conversation

@jezekra1
Copy link
Collaborator

@jezekra1 jezekra1 commented Jan 8, 2026

Summary

Add platform proxy auth schemes to agent card schemes:

        "security": [
          {
            "platform_context_token": []
          },
          {
            "platform_context_token": [],
            "basic": []
          }
        ],
        "securitySchemes": {
          "platform_context_token": {
            "bearerFormat": "JWT",
            "description": "Platform context token, issued by the AgentStack server using POST /api/v1/context/{context_id}/token.",
            "scheme": "bearer",
            "type": "http"
          },
          "basic": {
            "bearerFormat": null,
            "description": null,
            "scheme": "basic",
            "type": "http"
          }
        },

Linked Issues

Documentation

  • No Docs Needed:

If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.

@jezekra1 jezekra1 requested a review from pilartomas January 8, 2026 14:28
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 8, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jezekra1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors and standardizes the declaration of authentication security schemes within the AgentStack server and SDK, particularly for agent cards. It introduces a new SdkAuthenticationBackend interface, enabling authentication providers to dynamically inject their supported security mechanisms, such as platform_context_token (JWT bearer), into the agent's metadata. This change ensures that agent cards accurately communicate their authentication requirements, improving interoperability and security configuration.

Highlights

  • Standardized Agent Card Security: Introduces a consistent way to declare authentication schemes for agent cards, specifically adding platform_context_token as a bearer JWT scheme.
  • Authentication Backend Interface: Defines a new abstract base class SdkAuthenticationBackend to allow custom authentication backends to programmatically update agent card security metadata.
  • Refactored Authentication Handling: Modifies the SDK's create_app function to remove direct AuthenticationMiddleware setup, implying that authentication configuration is now handled more dynamically via the SdkAuthenticationBackend.
  • Proxy and Deployment Agent Card Updates: Ensures that both proxy and deployment agent cards correctly reflect the new platform_context_token and other configured authentication schemes (OIDC bearer, basic).

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors authentication handling in the SDK to allow authentication backends to modify the agent card's security schemes, which is a solid architectural improvement. It correctly introduces an abstract base class for this purpose. However, there is a critical flaw in how the proxy server combines its own security requirements with those of the upstream agent. The current implementation incorrectly requires clients to authenticate with both the proxy and the agent simultaneously, which defeats the purpose of a proxy. I've provided a detailed comment and a code suggestion to rectify this by ensuring the proxy advertises its own authentication schemes, replacing the agent's.

@jezekra1 jezekra1 force-pushed the fix-a2a-proxy-security-schemes branch from 76023c3 to 7ee0fce Compare January 9, 2026 08:18
Comment on lines -35 to -45
proxy_security = []
proxy_security_schemes = {}
if not configuration.auth.disable_auth:
# Note that we're purposefully not using oAuth but a more generic http scheme.
# This is because we don't want to declare the auth metadata but prefer discovery through related RFCs
# The http scheme also covers internal jwt tokens
proxy_security.append({"bearer": []})
proxy_security_schemes["bearer"] = SecurityScheme(HTTPAuthSecurityScheme(scheme="bearer"))
if configuration.auth.basic.enabled:
proxy_security.append({"basic": []})
proxy_security_schemes["basic"] = SecurityScheme(HTTPAuthSecurityScheme(scheme="basic"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this truly gone? I thought user token is also accepted, at least it has a2a_proxy scope right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants