-
Notifications
You must be signed in to change notification settings - Fork 399
DeepEval Tutorial #1352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
DeepEval Tutorial #1352
Conversation
Updated links and references to DeepEval documentation for clarity and accuracy. Signed-off-by: yatishdurga <[email protected]>
DeepEval tutorial
Summary of ChangesHello @yatishdurga, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new, detailed tutorial document that outlines the process of evaluating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new tutorial for using DeepEval with BeeAI's RequirementAgent. The document is well-structured and provides a clear, step-by-step guide for setting up an evaluation pipeline. My review focuses on ensuring the accuracy and consistency of the provided links to external resources and source code. I've identified a few links that point to personal forks or outdated domains, which should be corrected to provide a better experience for users following the tutorial. Overall, this is a valuable addition to the documentation.
python/eval/DeepEval tutorial.mdx
Outdated
| ### **Parallel execution** | ||
| `create_dataset` uses `asyncio.gather` to run multiple evaluations in parallel, which speeds up testing. | ||
|
|
||
| - [`BeeAI eval utils (_utils.py)`](<https://github.com/yatishdurga/beeai-framework/blob/main/python/eval/_utils.py>) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link for BeeAI eval utils (_utils.py) points to a personal fork of the repository (yatishdurga/beeai-framework) instead of the main i-am-bee/beeai-framework repository. This can be confusing and lead users to an unofficial or outdated version of the code. Please update the link to point to the correct repository.
- [`BeeAI eval utils (_utils.py)`](<https://github.com/i-am-bee/beeai-framework/blob/main/python/eval/_utils.py>)
python/eval/DeepEval tutorial.mdx
Outdated
| - Include negative cases (ambiguous inputs requiring clarification) | ||
| - Add multilingual tests if the agent supports multiple languages | ||
|
|
||
| [`DeepEval Golden docs`](https://docs.confident-ai.com/docs/datasets) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link to "DeepEval Golden docs" points to an old domain (docs.confident-ai.com). While it may redirect for now, it's best to update it to the current DeepEval domain to avoid future breakage and ensure users land on the most up-to-date documentation.
[`DeepEval Golden docs`](https://docs.deepeval.com/docs/datasets-and-test-cases)
python/eval/DeepEval tutorial.mdx
Outdated
| - Include edge cases | ||
| - Include “failure modes” | ||
|
|
||
| - [`BeeAI environment config docs`](https://agentstack.beeai.dev/introduction/quickstart#configure-the-llm-provider) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link for "BeeAI environment config docs" uses the agentstack.beeai.dev domain, which is inconsistent with other BeeAI documentation links in this file that use framework.beeai.dev. To maintain consistency and avoid confusion, please verify and use the correct, canonical domain for the documentation. framework.beeai.dev appears to be the current standard.
- [`BeeAI environment config docs`](https://framework.beeai.dev/introduction/quickstart#configure-the-llm-provider)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work. However I don't see any code example showcasing how one can really do some sort of evaluation. This is a crucial part. The tutorial should be practical.
|
Thank you for the feedback @Tomas2D I will update the documentation to include: |
Expanded the DeepEval tutorial with detailed evaluation steps, examples, and best practices for using RequirementAgent. Signed-off-by: yatishdurga <[email protected]>
Signed-off-by: yatishdurga <[email protected]>
|
Hi @Tomas2D , Thank you . |
|
Please update links in the tutorial so that they don't point to your repository. Use relative paths. |
Signed-off-by: yatishdurga <[email protected]>
Signed-off-by: yatishdurga <[email protected]>
|
Hi @Tomas2D , I have updated with the relative path .Please have a look at it. |
Which issue(s) does this pull-request address?
Closes: #
Description
Checklist
General
/ TypeScript
Pythonfor Python changes,TypeScriptfor TypeScript changesCode quality checks
mise check(mise fixto auto-fix)Testing
mise test:unitmise test:e2eDocumentation
mise docs:fix