feat: make Solidity `V8` migration non breaking #306

Le-Caignec · 2025-10-28T12:07:53Z

Gas Study

…ter clarity

…exec contracts

Copilot

Pull Request Overview

This pull request removes the IexecEscrowTokenSwapFacet and migrates the codebase from Solidity v0.6.0 to v0.8.0, making the v8 migration non-breaking by consolidating storage libraries and updating registry contracts to use OpenZeppelin v5.

Key changes:

Removed IexecEscrowTokenSwapFacet and related token swap functionality
Upgraded Solidity version from 0.6.0 to 0.8.0 across registry and test contracts
Consolidated PocoStorageLib.v8.sol into PocoStorageLib.sol
Updated registry contracts to use OpenZeppelin contracts v5 (ERC721Enumerable, Ownable)

Reviewed Changes

Copilot reviewed 73 out of 73 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
utils/proxy-tools.ts	Removed imports and references to IexecEscrowTokenSwapFacet
scripts/tools/sol-to-uml.mjs	Removed IexecEscrowTokenSwapFacet from UML diagram generation
hardhat.config.ts	Removed exclusions for files that no longer exist
docs/solidity/index.md	Regenerated documentation with updated structure and removed TokenSwap references
deploy/0_deploy.ts	Fixed import path for Ownable factory and removed TokenSwap deployment comment
contracts/tools/testing/*.sol	Upgraded Solidity version to 0.8.0 and removed unnecessary constructors
contracts/registries/*/.sol	Upgraded to Solidity 0.8.0, OpenZeppelin v5, and updated type casting for address-to-uint conversions
contracts/registries/proxy/*.sol	Added proxy contracts copied from iexec-solidity with pragma updates
contracts/libs/PocoStorageLib.sol	Consolidated v8 storage lib, updated imports, and fixed assembly syntax
contracts/interfaces/*	Created IexecHubV3Interface, removed IexecEscrowTokenSwap, updated event declarations
contracts/facets/*.sol	Updated all facets to use consolidated PocoStorageLib and replaced SafeMathExtended with native operators
abis/contracts/*/.json	Updated ABIs to reflect OpenZeppelin v5 error types and parameter name changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

deploy/0_deploy.ts

contracts/registries/RegistryEntry.sol

contracts/registries/Registry.sol

contracts/facets/SignatureVerifier.sol

contracts/facets/IexecConfigurationFacet.sol

contracts/facets/IexecConfigurationExtraFacet.sol

Copilot

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…y, and WorkerpoolRegistry for enhanced deployment handling

…y documentation for Iexec interfaces and methods

…f JSON files and updating initialization logic in Registry contract

…y documentation for new methods in Iexec contracts

Copilot

Pull Request Overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

contracts/registries/apps/AppRegistry.sol

contracts/registries/datasets/DatasetRegistry.sol

contracts/registries/workerpools/WorkerpoolRegistry.sol

contracts/registries/Registry.sol

contracts/registries/apps/AppRegistry.sol

contracts/registries/datasets/DatasetRegistry.sol

contracts/registries/workerpools/WorkerpoolRegistry.sol

…acet to prevent underflow and ensure backward compatibility

…y documentation for Iexec contracts

…mpatibility

…statements in test files for consistency

Copilot

Pull Request Overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

contracts/facets/IexecERC20Facet.sol

contracts/facets/IexecERC20Core.sol

test/byContract/registries/registries.test.ts

codecov · 2025-10-28T16:15:22Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.32%. Comparing base (4bab677) to head (31096ca).

Additional details and impacted files

@@                  Coverage Diff                  @@
##           chore/solidity-v8     #306      +/-   ##
=====================================================
+ Coverage              96.26%   96.32%   +0.06%     
=====================================================
  Files                     34       34              
  Lines                   1099     1117      +18     
  Branches                 203      209       +6     
=====================================================
+ Hits                    1058     1076      +18     
  Misses                    41       41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 12 out of 15 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-30T09:31:25Z

contracts/interfaces/IexecERC20.sol


 import {IexecERC20Common} from "./IexecERC20Common.sol";


The pragma experimental ABIEncoderV2; directive is unnecessary and deprecated in Solidity 0.8.0+. ABIEncoderV2 is enabled by default in Solidity 0.8.0 and later versions, so this pragma should be removed.

Suggested change

import {IexecERC20Common} from "./IexecERC20Common.sol";

possible to remove or should we consider to keep ?

it have been done in this PR. #308
My goal here was simply to patch the functions to make the tests pass.
As discuss Timelock will be removed in a dedicated PR

gfournieriExec · 2025-10-30T10:13:59Z

Are we sure we want to set
pragma solidity >=0.8.0 instead of pragma solidity ^0.8.0; ?

…d library files

… storing account balance in a variable

… adding new escrow facets

…ying balance retrieval

Copilot

Pull Request Overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

contracts/registries/apps/AppRegistry.sol

…to streamline deployment by consolidating migration checks into _mintCreate function. This change enhances backward compatibility and prepares for future updates.

…aset structures, update function signatures, and enhance clarity by removing outdated interfaces. This update includes the addition of new methods for managing categories, datasets, and worker pools, ensuring better organization and maintainability.

contracts/facets/IexecERC20Facet.sol

contracts/registries/apps/AppRegistry.sol

contracts/registries/datasets/DatasetRegistry.sol

contracts/registries/workerpools/WorkerpoolRegistry.sol

Co-authored-by: Zied Guesmi <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

contracts/registries/Registry.sol

…nd WorkerpoolRegistry to improve readability by directly returning the result of the _mintCreate function, eliminating intermediate variables.

…es, enhancing clarity and maintainability. This update introduces new methods for interacting with PoCo contracts, updates function signatures, and ensures backward compatibility with existing SDK references.

…n-non-breaking

Copilot

Pull Request Overview

Copilot reviewed 24 out of 24 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

contracts/facets/IexecERC20Facet.sol

contracts/facets/IexecERC20Core.sol

zguesmi

Well done!

zguesmi · 2025-11-03T15:42:37Z

To not be merged yet!

…reaking

Le-Caignec added 2 commits October 28, 2025 13:03

refactor: Update test assertions to use revertedWithoutReason for bet…

d26565f

…ter clarity

docs: Expand Solidity documentation with new facets and methods for I…

b727db9

…exec contracts

Copilot AI review requested due to automatic review settings October 28, 2025 12:07

Le-Caignec self-assigned this Oct 28, 2025

Copilot AI reviewed Oct 28, 2025

View reviewed changes

Le-Caignec changed the base branch from main to chore/solidity-v8 October 28, 2025 12:10

Le-Caignec requested a review from Copilot October 28, 2025 12:10

Copilot AI reviewed Oct 28, 2025

View reviewed changes

Le-Caignec added 4 commits October 28, 2025 14:36

feat: Add internal_mintCreate function to AppRegistry, DatasetRegistr…

6df3e1d

…y, and WorkerpoolRegistry for enhanced deployment handling

fix: Add missing newlines at the end of JSON files and update Solidit…

8ff72ac

…y documentation for Iexec interfaces and methods

fix: Ensure proper formatting by adding missing newlines at the end o…

59f12bd

…f JSON files and updating initialization logic in Registry contract

fix: Add missing newlines at the end of JSON files and update Solidit…

89c4617

…y documentation for new methods in Iexec contracts

Copilot AI review requested due to automatic review settings October 28, 2025 14:22

Copilot AI reviewed Oct 28, 2025

View reviewed changes

Le-Caignec added 4 commits October 28, 2025 16:28

fix: Add temporary migration checks in IexecERC20Core and IexecERC20F…

599cd76

…acet to prevent underflow and ensure backward compatibility

fix: Add missing newlines at the end of JSON files and update Solidit…

28e0251

…y documentation for Iexec contracts

fix: Add temporary migration checks in IexecERC20Core for backward co…

4f69ec2

…mpatibility

fix: Add missing newlines at the end of JSON files and update import …

b011731

…statements in test files for consistency

Copilot AI review requested due to automatic review settings October 28, 2025 16:07

Copilot AI reviewed Oct 28, 2025

View reviewed changes

contracts/facets/IexecERC20Facet.sol Outdated Show resolved Hide resolved

contracts/facets/IexecERC20Facet.sol Show resolved Hide resolved

contracts/facets/IexecERC20Core.sol Outdated Show resolved Hide resolved

test/byContract/registries/registries.test.ts Outdated Show resolved Hide resolved

Le-Caignec and others added 3 commits October 28, 2025 17:19

fix: Reorder import statements in test file for consistency and clarity

2cce4c7

fix: Rollback modif

9ddf6b3

Update test/byContract/registries/registries.test.ts

a5db074

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings October 28, 2025 16:27

iExecBlockchainComputing deleted a comment from Copilot AI Oct 28, 2025

Copilot AI reviewed Oct 28, 2025

View reviewed changes

Le-Caignec marked this pull request as ready for review October 28, 2025 16:28

Le-Caignec requested review from gfournieriExec and zguesmi as code owners October 28, 2025 16:28

Le-Caignec and others added 2 commits October 30, 2025 10:30

Update contracts/interfaces/IexecERC20Common.sol

ea871ea

Co-authored-by: Copilot <[email protected]>

Update contracts/interfaces/IexecERC20.sol

c5a145f

Co-authored-by: Copilot <[email protected]>

Copilot AI reviewed Oct 30, 2025

View reviewed changes

Le-Caignec added 4 commits October 30, 2025 14:22

Update Solidity pragma version to ^0.8.0 across multiple interface an…

94328c6

…d library files

Implement feature X to enhance user experience and fix bug Y in module Z

2252323

Refactor _burn function to improve readability and maintainability by…

abfa39e

… storing account balance in a variable

Update Solidity API documentation by removing outdated interfaces and…

c63bdb9

… adding new escrow facets

Copilot AI review requested due to automatic review settings October 30, 2025 14:48

Refactor _transferUnchecked function to improve readability by clarif…

fcbeb75

…ying balance retrieval

Copilot AI reviewed Oct 30, 2025

View reviewed changes

zguesmi requested changes Oct 31, 2025

View reviewed changes

contracts/registries/apps/AppRegistry.sol Outdated Show resolved Hide resolved

Le-Caignec added 2 commits October 31, 2025 14:53

Refactor contract creation process in Registry and derived contracts …

6415a36

…to streamline deployment by consolidating migration checks into _mintCreate function. This change enhances backward compatibility and prepares for future updates.

Le-Caignec requested a review from zguesmi October 31, 2025 14:27

zguesmi reviewed Nov 3, 2025

View reviewed changes

Update contracts/facets/IexecERC20Facet.sol

caced1d

Co-authored-by: Zied Guesmi <[email protected]>

Copilot AI review requested due to automatic review settings November 3, 2025 13:31

Update contracts/facets/IexecERC20Facet.sol

5c6b124

Co-authored-by: Zied Guesmi <[email protected]>

Copilot AI reviewed Nov 3, 2025

View reviewed changes

contracts/registries/Registry.sol Show resolved Hide resolved

contracts/registries/Registry.sol Show resolved Hide resolved

Le-Caignec added 2 commits November 3, 2025 14:42

Refactor contract creation methods in AppRegistry, DatasetRegistry, a…

1ddcd80

…nd WorkerpoolRegistry to improve readability by directly returning the result of the _mintCreate function, eliminating intermediate variables.

Refactor Solidity API documentation to rename and reorganize interfac…

427bb59

…es, enhancing clarity and maintainability. This update introduces new methods for interacting with PoCo contracts, updates function signatures, and ensures backward compatibility with existing SDK references.

Le-Caignec requested a review from zguesmi November 3, 2025 13:46

chore: Merge branch 'chore/solidity-v8' into feature/make-v8-migratio…

7f3ca8a

…n-non-breaking

Copilot AI review requested due to automatic review settings November 3, 2025 15:40

Copilot AI reviewed Nov 3, 2025

View reviewed changes

contracts/facets/IexecERC20Facet.sol Show resolved Hide resolved

contracts/facets/IexecERC20Core.sol Show resolved Hide resolved

contracts/facets/IexecERC20Core.sol Show resolved Hide resolved

zguesmi approved these changes Nov 3, 2025

View reviewed changes

gfournieriExec approved these changes Nov 3, 2025

View reviewed changes

Merge branch 'chore/solidity-v8' into feature/make-v8-migration-non-b…

31096ca

…reaking

feat: make Solidity V8 migration non breaking #306

Are you sure you want to change the base?

feat: make Solidity V8 migration non breaking #306

Conversation

Le-Caignec commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

gfournieriExec Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Le-Caignec Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gfournieriExec commented Oct 30, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

feat: make Solidity `V8` migration non breaking #306

feat: make Solidity `V8` migration non breaking #306

Le-Caignec commented Oct 28, 2025 •

edited

Loading

codecov bot commented Oct 28, 2025 •

edited

Loading

Le-Caignec Oct 30, 2025 •

edited

Loading