feat: clean OpenZeppelin dual-version setup #308
Conversation
…y, and WorkerpoolRegistry for enhanced deployment handling
…y documentation for Iexec interfaces and methods
…f JSON files and updating initialization logic in Registry contract
…y documentation for new methods in Iexec contracts
…acet to prevent underflow and ensure backward compatibility
…y documentation for Iexec contracts
…statements in test files for consistency
Co-authored-by: Copilot <[email protected]>
…ub.com/iExecBlockchainComputing/PoCo into feature/make-v8-migration-non-breaking
…ns and adding new contract interfaces for improved clarity and organization
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades OpenZeppelin Contracts from version 3.3.0 to 5.4.0 by removing the dual-version setup (@openzeppelin/contracts v3.3.0 and @openzeppelin/contracts-v5 alias) in favor of a single v5 installation. The change removes a custom TimelockController implementation and adopts the official OpenZeppelin v5 TimelockController contract.
Key changes:
- Replaced dual OpenZeppelin package setup with single v5.4.0 version
- Updated all import paths from
@openzeppelin/contracts-v5to@openzeppelin/contracts - Removed custom TimelockController contract (Solidity 0.6) in favor of OpenZeppelin's v5 implementation
- Updated hardhat config to compile OpenZeppelin's TimelockController for deployment
Reviewed Changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated OpenZeppelin dependency from dual v3.3.0/v5.0.2 setup to single v5.4.0, removed TimelockController exclusion |
| package-lock.json | Updated lock file to reflect new OpenZeppelin v5.4.0 dependency resolution |
| hardhat.config.ts | Updated import paths and added OpenZeppelin TimelockController to external compilation list |
| contracts/tools/TimelockController.sol | Removed custom Solidity 0.6 implementation |
| contracts/registries/*.sol | Updated import paths from @openzeppelin/contracts-v5 to @openzeppelin/contracts |
| contracts/libs/PocoStorageLib.sol | Updated IERC20 import path |
| contracts/facets/*.sol | Updated all OpenZeppelin import paths and reformatted IexecPoco1Facet contract declaration |
| contracts/tools/testing/*.sol | Updated mock contract import paths |
| abis/contracts/registries/*.json | Updated error definitions to match OpenZeppelin v5 (renamed Create2* errors to match new naming) |
| abis/contracts/facets/IexecPoco2Facet.json | Removed MathOverflowedMulDiv error (no longer exposed in v5) |
| docs/solidity/index.md | Reorganized documentation sections (content unchanged, only ordering) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…rations for enhanced security in maintenance tasks
… proper formatting
Le-Caignec
changed the title
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 23 out of 24 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 36 out of 37 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…eaking' into feat/clean-dep
…ith new error handling and function signatures. Add new error definitions in Errors.sol and Strings.sol. Introduce IERC165 and ERC165 interfaces. Update ERC20, ERC721, and related interfaces to reflect current standards. Enhance error handling in various contracts, including Create2 and ECDSA.
…arious platforms including solidity analyzers for darwin, freebsd, linux, and win32 environments
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 49 out of 67 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Deleted the deploy-timelock.ts script as it is no longer needed. - Removed goerli.sh and mainnet.sh scripts for ENS management. - Deleted getWorker.py script used for score importing. - Removed sponsoring deployment and module addition scripts along with their README and upgrade status documentation. - Updated package.json to remove timelock deployment command and adjusted dependencies. - Modified check-storage.ts to skip contracts from rlc-faucet-contract.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 43 out of 61 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 28 out of 49 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 participants
This PR upgrades OpenZeppelin Contracts from version 3.3.0 to 5.4.0 by removing the dual-version setup (@openzeppelin/contracts v3.3.0 and @openzeppelin/contracts-v5 alias) in favor of a single v5 installation.