Skip to content

Conversation

@zguesmi
Copy link
Member

@zguesmi zguesmi commented Nov 4, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 4, 2025 16:56
@zguesmi zguesmi self-assigned this Nov 4, 2025
@zguesmi zguesmi marked this pull request as ready for review November 4, 2025 16:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates the SignatureVerifier implementation by removing the duplicate SignatureVerifier.v8.sol file and updating SignatureVerifier.sol to use Solidity 0.8.0. All references throughout the codebase are updated to use the single consolidated implementation.

Key changes:

  • Removed duplicate SignatureVerifier.v8.sol file
  • Updated SignatureVerifier.sol from Solidity 0.6 to 0.8 with modern OpenZeppelin imports
  • Updated all import statements across facet files to reference the consolidated implementation
  • Removed outdated ABI files for legacy interfaces
  • Updated configuration files to reflect the consolidation

Reviewed Changes

Copilot reviewed 12 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
hardhat.config.ts Removed exclusion of SignatureVerifier.v8.sol from documentation generation
contracts/facets/SignatureVerifier.v8.sol Deleted duplicate v8 implementation file
contracts/facets/SignatureVerifier.sol Updated to Solidity 0.8 with modern dependencies and implementation
contracts/facets/IexecPocoBoostFacet.sol Updated import to reference consolidated SignatureVerifier
contracts/facets/IexecPocoAccessorsFacet.sol Updated import to reference consolidated SignatureVerifier
contracts/facets/IexecPoco2Facet.sol Updated import to reference consolidated SignatureVerifier
contracts/facets/IexecPoco1Facet.sol Updated import to reference consolidated SignatureVerifier
contracts/facets/IexecOrderManagementFacet.sol Updated import to reference consolidated SignatureVerifier
docs/uml/*.svg Regenerated UML diagrams reflecting the consolidated architecture
abis/human-readable-abis/* Removed ABI files for legacy ERC interfaces no longer directly imported
.solcover.js Removed skip directive for SignatureVerifier.sol to enable coverage

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.53%. Comparing base (3b28585) to head (678fa98).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #315   +/-   ##
=======================================
  Coverage   96.53%   96.53%           
=======================================
  Files          32       32           
  Lines        1069     1069           
  Branches      213      213           
=======================================
  Hits         1032     1032           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zguesmi zguesmi merged commit d0bc2be into main Nov 5, 2025
11 checks passed
@zguesmi zguesmi deleted the chore/remove-signature-verifier-solv6-contract branch November 5, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants