feat: upgrade access feature #91
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted state management
…als tables using useEffect
…mic page visibility
…al count for apps, datasets, and workerpools
Co-authored-by: Copilot <[email protected]>
…ockchainComputing/explorer-v2 into feature/add-assets-order
…ets, and workerpools
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ErwanDecoster
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR implements comprehensive access management functionality across the application, adding dedicated views for managing access permissions on apps, datasets, and workerpools. The changes include tab-based navigation, improved loading states, and a new access detail page.
- Introduces access tabs for apps, datasets, and workerpools with dedicated access tables
- Adds new route for viewing individual access details
- Refactors
getTokenSymbolutility to support dynamic chain IDs - Improves pagination and tab indicator behavior
- Updates iExec SDK integration to support readonly mode
Reviewed Changes
Copilot reviewed 48 out of 49 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/chain.utils.ts | Extracts getTokenSymbol to standalone utility function accepting chainId parameter |
| src/routes/$chainSlug/_layout/workerpool/$workerpoolAddress.tsx | Adds tab navigation with ACCESS tab and child loading/outdated state management |
| src/routes/$chainSlug/_layout/dataset/$datasetAddress.tsx | Adds tab navigation with ACCESS tab and child loading/outdated state management |
| src/routes/$chainSlug/_layout/app/$appAddress.tsx | Adds tab navigation with ACCESS tab and child loading/outdated state management |
| src/routes/$chainSlug/_layout/address/$addressAddress.tsx | Adds RECEIVED ACCESS and GRANTED ACCESS tabs with corresponding table components |
| src/routes/$chainSlug/_layout/access/$accessHash.tsx | New route for displaying individual access order details |
| src/routeTree.gen.ts | Generated routing configuration for new access route |
| src/modules/workerpools/workerpool/WorkerpoolDealsTable.tsx | Refactors to accept loading/outdated callbacks and removes redundant header |
| src/modules/workerpools/workerpool/WorkerpoolAccessTable.tsx | New table component for displaying workerpool access orders |
| src/modules/datasets/dataset/DatasetDealsTable.tsx | Refactors to accept loading/outdated callbacks and removes redundant header |
| src/modules/datasets/dataset/DatasetAccessTable.tsx | New table component for displaying dataset access orders |
| src/modules/apps/app/AppDealsTable.tsx | Refactors to accept loading/outdated callbacks and removes redundant header |
| src/modules/apps/app/AppAccessTable.tsx | New table component for displaying app access orders |
| src/modules/deals/dealsTable/columns.tsx | Updates to use refactored getTokenSymbol with chainId parameter |
| src/modules/addresses/address/*/AddressApps/Datasets/WorkerpoolsReceivedAccessTable.tsx | New components for address received access management |
| src/modules/addresses/address/*/AddressApps/Datasets/WorkerpoolsGrantedAccessTable.tsx | New components for address granted access management |
| src/modules/access/*Columns.tsx | New column definitions for access tables (app, dataset, workerpool) |
| src/modules/access/access/buildAccessDetails.tsx | New utility to build access detail view data |
| src/modules/access/access/AccessBreadcrumbs.tsx | New breadcrumb component for access pages |
| src/modules/Tabs.tsx | Fixes tab indicator positioning to account for scroll position |
| src/hooks/ChainSyncManger.ts | Refactors iExec SDK initialization logic |
| src/externals/iexecSdkClient.ts | Updates SDK client to support initialization with chainId for readonly mode |
| src/components/icons/AccessIcon.tsx | New icon component for access views |
| src/components/SmartLinkGroup.tsx | Adds 'order' link type support |
| src/components/PaginatedNavigation.tsx | Improves pagination stability and mobile responsiveness |
| src/components/DataTable.tsx | Conditionally applies cursor-pointer only when destination exists |
| package.json | Updates iexec SDK to version 8.20.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…page in access tables
… in RevokeAccess component
…nd label; update access details functions to include app, dataset, and workerpool information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.