Skip to content

feat: deprecate classes based on deprecated EIP-712 implementation #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2025
Merged

feat: deprecate classes based on deprecated EIP-712 implementation #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
697955c
feat: deprecate classes based on deprecated EIP-712 implementation
jbern0rd Oct 24, 2025
3213de8
fix: remove unwanted import
jbern0rd Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/com/iexec/commons/poco/eip712/EIP712.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@
import java.util.List;
import java.util.Map;

/**
* @deprecated only used in {@link EIP712Entity}
*/
@Deprecated(forRemoval = true)
@JsonIgnoreProperties(ignoreUnknown = true)
public interface EIP712<M> {

Expand Down
4 changes: 4 additions & 0 deletions src/main/java/com/iexec/commons/poco/eip712/entity/EIP712AppOrder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@
import java.util.Arrays;
import java.util.List;

/**
* @deprecated replaced with {@link AppOrder#computeHash(EIP712Domain)} )
*/
@Deprecated(forRemoval = true)
@Getter
@NoArgsConstructor
public class EIP712AppOrder extends EIP712Entity<AppOrder> {
Expand Down
6 changes: 2 additions & 4 deletions src/main/java/com/iexec/commons/poco/eip712/entity/EIP712Challenge.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,9 @@
import java.util.List;

/**
* EIP-712 compliant challenge based on {@link Challenge} type and {@link EIP712Domain}.
* <p>
* In the current implementation, {@link EIP712Domain} fields are {@code name}, {@code version} and {@code chainID}.
* There is no {@code verifyingContract}.
* @deprecated replaced with {@link Challenge#computeHash(EIP712Domain)} )
*/
@Deprecated(forRemoval = true)
@NoArgsConstructor
public class EIP712Challenge extends EIP712Entity<Challenge> {

Expand Down
4 changes: 4 additions & 0 deletions src/main/java/com/iexec/commons/poco/eip712/entity/EIP712DatasetOrder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@
import java.util.Arrays;
import java.util.List;

/**
* @deprecated replaced with {@link DatasetOrder#computeHash(EIP712Domain)} )
*/
@Deprecated(forRemoval = true)
@Getter
@NoArgsConstructor
public class EIP712DatasetOrder extends EIP712Entity<DatasetOrder> {
Expand Down
4 changes: 4 additions & 0 deletions src/main/java/com/iexec/commons/poco/eip712/entity/EIP712RequestOrder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@
import java.util.Arrays;
import java.util.List;

/**
* @deprecated replaced with {@link RequestOrder#computeHash(EIP712Domain)} )
*/
@Deprecated(forRemoval = true)
@Getter
@NoArgsConstructor
public class EIP712RequestOrder extends EIP712Entity<RequestOrder> {
Expand Down
4 changes: 4 additions & 0 deletions src/main/java/com/iexec/commons/poco/eip712/entity/EIP712WorkerpoolOrder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@
import java.util.Arrays;
import java.util.List;

/**
* @deprecated replaced with {@link WorkerpoolOrder#computeHash(EIP712Domain)} )
*/
@Deprecated(forRemoval = true)
@Getter
@NoArgsConstructor
public class EIP712WorkerpoolOrder extends EIP712Entity<WorkerpoolOrder> {
Expand Down