fix(conversation): keep older-history pagination reliable during running turns - #4233
Open
turingcat wants to merge 1 commit into
Open
fix(conversation): keep older-history pagination reliable during running turns#4233turingcat wants to merge 1 commit into
turingcat wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While a conversation turn is running, older message history can silently become unreachable, and the pagination/auto-scroll state around history loading can get corrupted:
onScroll, it never fires even though more history exists.MessageList.tsxnow proactively pulls older pages (capped atMAX_VIEWPORT_FILL_PAGES) after mount/prepend as long as content still fits without a scrollbar.oldestCursor/hasMoreBefore), a pending turn completing would reload the newest page and reset pagination as if it were a fresh mount, discarding that progress.loadMessagesnow accepts apreservePaginationBeforeoption, used by the turn-completion reconciliation path.useAutoScrollmisidentified prepended history as a new message. It compared onlymessages.lengthto detect "a new message arrived," but a prepended older page also grows the list length. It now compares the tail message byidinstead.Related Issues
Type of Change
fix— Bug fix (non-breaking change which fixes an issue)Atomic PR Checklist (Rule 1)
<type>(<scope>): <subject>(English)Local Checks (Rule 3)
bun run format— formatting passesbun run lint— no lint errors (skip if no.ts/.tsxchanged)bunx tsc --noEmit— no type errors (skip if no.ts/.tsxchanged)bunx vitest run— tests pass (520 files / 4984 tests passed)Runtime Verification
Additional Context
Regression tests added in
tests/unit/renderer/messageList.dom.test.tsx,tests/unit/renderer/messageMerging.dom.test.tsx, andtests/unit/renderer/useAutoScroll.dom.test.tsx.