Added perf tests for incremental schema loading #8698
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,727 @@ | |||
| /*--------------------------------------------------------------------------------------------- | |||
Contributor
There was a problem hiding this comment.
There are a lot of exports, since these types aren't used anywhere outside this file, we should not export that.
| schemaItemCount?: number; | ||
| } | ||
|
|
||
| describe("IncrementalLoadingPerformance", async () => { |
Contributor
There was a problem hiding this comment.
We should not use async functions in describe because I noticed Mocha is executing them directly and if you use only for example, it still be executed. better wrap the async stuff in a before block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.