-
Notifications
You must be signed in to change notification settings - Fork 0
Components: Fix ContentDataProvider.getFieldByPropertyDescription not finding array item and struct member fields
#1161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…rray item and struct member fields.
🦋 Changeset detectedLatest commit: 5b805f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unified selection benchmark
| Benchmark suite | Current: 5b805f8 | Previous: 016d31e | Deviation | Status |
|---|---|---|---|---|
hilite 50k elements |
1280.26 ms |
1320.88 ms |
-3.08% |
〰️ |
hilite 50k elements (P95 of main thread blocks) |
49 ms |
50 ms |
-2% |
〰️ |
hilite 50k group elements |
236.19 ms |
233.18 ms |
1.29% |
〰️ |
hilite 50k group elements (P95 of main thread blocks) |
33 ms |
33 ms |
0% |
🟰 |
hilite 1k subjects |
46910.85 ms |
45515.87 ms |
3.06% |
〰️ |
hilite 1k subjects (P95 of main thread blocks) |
30 ms |
31 ms |
-3.23% |
〰️ |
hilite 50k subcategories |
281.93 ms |
274.83 ms |
2.58% |
〰️ |
hilite 50k subcategories (P95 of main thread blocks) |
35 ms |
34 ms |
2.94% |
〰️ |
hilite 50k functional 3D elements |
27891.82 ms |
28077.46 ms |
-0.66% |
〰️ |
hilite 50k functional 3D elements (P95 of main thread blocks) |
37 ms |
44 ms |
-15.91% |
〰️ |
hilite 50k functional 2D elements |
6618.33 ms |
6451.68 ms |
2.58% |
〰️ |
hilite 50k functional 2D elements (P95 of main thread blocks) |
42 ms |
42 ms |
0% |
🟰 |
compute selection for 50k elements |
336.42 ms |
308.47 ms |
9.06% |
〰️ |
compute selection for 50k elements (P95 of main thread blocks) |
37 ms |
31 ms |
19.35% |
〰️ |
compute parent selection for 50k elements |
342.81 ms |
328.1 ms |
4.48% |
〰️ |
compute parent selection for 50k elements (P95 of main thread blocks) |
32 ms |
32 ms |
0% |
🟰 |
compute top ancestor selection for 50k elements |
560.85 ms |
552.66 ms |
1.48% |
〰️ |
compute top ancestor selection for 50k elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute category selection for 50k elements |
90.52 ms |
90.95 ms |
-0.47% |
〰️ |
compute category selection for 50k elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute model selection for 50k elements |
71.51 ms |
68.46 ms |
4.46% |
〰️ |
compute model selection for 50k elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute functional selection for 50k 3D elements |
406.32 ms |
381.68 ms |
6.46% |
〰️ |
compute functional selection for 50k 3D elements (P95 of main thread blocks) |
31 ms |
30 ms |
3.33% |
〰️ |
compute parent functional selection for 50k 3D elements |
436.07 ms |
438.78 ms |
-0.62% |
〰️ |
compute parent functional selection for 50k 3D elements (P95 of main thread blocks) |
31 ms |
31 ms |
0% |
🟰 |
compute top ancestor functional selection for 50k 3D elements |
1188.29 ms |
1205.99 ms |
-1.47% |
〰️ |
compute top ancestor functional selection for 50k 3D elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute functional selection for 50k 2D elements |
3092.16 ms |
3006 ms |
2.87% |
〰️ |
compute functional selection for 50k 2D elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute parent functional selection for 50k 2D elements |
3056.78 ms |
3108.14 ms |
-1.65% |
〰️ |
compute parent functional selection for 50k 2D elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute top ancestor functional selection for 50k 2D elements |
3141.03 ms |
3063.35 ms |
2.54% |
〰️ |
compute top ancestor functional selection for 50k 2D elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hierarchies benchmark
| Benchmark suite | Current: 5b805f8 | Previous: 016d31e | Deviation | Status |
|---|---|---|---|---|
flat 50k elements list |
4475.09 ms |
4708.98 ms |
-4.97% |
〰️ |
flat 50k elements list (P95 of main thread blocks) |
69 ms |
77 ms |
-10.39% |
〰️ |
filtering filters with 50000 paths |
8456.45 ms |
9044.52 ms |
-6.50% |
〰️ |
filtering filters with 50000 paths (P95 of main thread blocks) |
119 ms |
129 ms |
-7.75% |
〰️ |
grouping by label |
9776.36 ms |
10070.84 ms |
-2.92% |
〰️ |
grouping by label (P95 of main thread blocks) |
50 ms |
58 ms |
-13.79% |
〰️ |
grouping by class |
9831.47 ms |
10100.12 ms |
-2.66% |
〰️ |
grouping by class (P95 of main thread blocks) |
35 ms |
37 ms |
-5.41% |
〰️ |
grouping by property |
10222.68 ms |
10861.62 ms |
-5.88% |
〰️ |
grouping by property (P95 of main thread blocks) |
43 ms |
52 ms |
-17.31% |
〰️ |
grouping by base class (10 classes) |
7382.44 ms |
7918.51 ms |
-6.77% |
〰️ |
grouping by base class (10 classes) (P95 of main thread blocks) |
73 ms |
50 ms |
46% |
〰️ |
grouping by multiple attributes |
25564.18 ms |
27137.62 ms |
-5.80% |
〰️ |
grouping by multiple attributes (P95 of main thread blocks) |
60 ms |
49 ms |
22.45% |
〰️ |
hide if no children required to finalize root, w/o children |
40608.45 ms |
46052.84 ms |
-11.82% |
✅ |
hide if no children required to finalize root, w/o children (P95 of main thread blocks) |
38 ms |
40 ms |
-5% |
〰️ |
hide if no children required to finalize root, w/ children |
161.94 ms |
174.21 ms |
-7.04% |
〰️ |
hide if no children required to finalize root, w/ children (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
models tree initial (Baytown) |
39.15 ms |
43.87 ms |
-10.76% |
〰️ |
models tree initial (Baytown) (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
models tree full (Baytown) |
6355.63 ms |
6885.57 ms |
-7.70% |
〰️ |
models tree full (Baytown) (P95 of main thread blocks) |
88 ms |
92 ms |
-4.35% |
〰️ |
models tree creates initial filtered view for 50k target items |
2114.53 ms |
2188.47 ms |
-3.38% |
〰️ |
models tree creates initial filtered view for 50k target items (P95 of main thread blocks) |
265 ms |
184 ms |
44.02% |
🚨 |
This comment was automatically generated by workflow using github-action-benchmark.
Closes #1156.
TODO: