Skip to content

Commit

Permalink
Merge pull request #80 from iamport/feat/js-sdk-1.3.0
Browse files Browse the repository at this point in the history
js sdk 1.3.0 업그레이드
  • Loading branch information
anymate98 authored Jul 25, 2024
2 parents d74368b + e89e049 commit e802d12
Show file tree
Hide file tree
Showing 13 changed files with 39 additions and 49 deletions.
2 changes: 1 addition & 1 deletion app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ dependencies {
implementation 'com.google.code.gson:gson:2.10.1'

implementation project(':sdk') // 가맹점은 이 코드가 아닌 아래와 같은 "버전"을 통한 implementation 으로 반영해주세요
// implementation 'com.github.iamport:iamport-android:1.3.4'
// implementation 'com.github.iamport:iamport-android:1.4.5'
// implementation 'com.github.iamport:iamport-android:fix~custom_data-SNAPSHOT'

}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,6 @@ class PaymentResultFragment : Fragment() {
if (iamPortResponse == null) {
return false
}
return iamPortResponse.success == true || iamPortResponse.imp_success == true
return iamPortResponse.imp_success == true || iamPortResponse.success == true || (iamPortResponse.error_code == null && iamPortResponse.code == null)
}
}
15 changes: 0 additions & 15 deletions build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
repositories {
google()
mavenCentral()
gradlePluginPortal()
maven { setUrl("https://jitpack.io") }
}
dependencies {
classpath("org.jetbrains.kotlin:kotlin-serialization:${Versions.kotlin_stdlib_jdk}")
}
Expand All @@ -16,15 +10,6 @@ plugins {
`update-dependency`
}

allprojects {
repositories {
google()
mavenCentral()
gradlePluginPortal()
maven { setUrl("https://jitpack.io") }
}
}

tasks.register<Delete>("clean") {
delete(rootProject.layout.buildDirectory)
}
13 changes: 5 additions & 8 deletions buildSrc/src/main/java/Dependencies.kt
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// 디펜던시 업데이트 확인 ./gradlew dependencyUpdates

object Versions {
const val versionCode = 240215000 // yymmdd000
const val versionName = "1.4.4" // https://www.notion.so/chaifinance/QA-Process-d1a4be396337493b81c6e85fff2d5cd6
const val versionCode = 240725000 // yymmdd000
const val versionName = "1.4.5" // https://www.notion.so/chaifinance/QA-Process-d1a4be396337493b81c6e85fff2d5cd6

const val multidex = "2.0.1"
const val kotlin_stdlib_jdk = "1.9.10"
Expand Down Expand Up @@ -44,14 +44,13 @@ object Versions {
const val rxandroid = "2.1.1"
const val rxjava2_debug = "1.4.0"

// loading animation
const val spinKit = "1.4.0"

const val robolectric = "4.7.3"

const val serialization = "1.6.0"

const val workRuntimeKtx = "2.8.1"

const val lottie = "6.4.1"
}

object Libs {
Expand Down Expand Up @@ -120,14 +119,12 @@ object Libs {
const val rxandroid = "io.reactivex.rxjava2:rxandroid:${Versions.rxandroid}"
const val rxjava2_debug = "com.akaita.java:rxjava2-debug:${Versions.rxjava2_debug}"

// loading animation
const val spinKit = "com.github.ybq:Android-SpinKit:${Versions.spinKit}"

const val serialization = "org.jetbrains.kotlinx:kotlinx-serialization-json:${Versions.serialization}"

// target android 12 pending intent 처리를 위해 추가
// Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent.
const val workRuntimeKtx = "androidx.work:work-runtime-ktx:${Versions.workRuntimeKtx}"

const val lottie = "com.airbnb.android:lottie:${Versions.lottie}"
}

10 changes: 1 addition & 9 deletions sdk/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,6 @@ android {
}
}

repositories {
flatDir {
dirs("libs")
}
}

compileOptions {
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
Expand Down Expand Up @@ -143,10 +137,8 @@ dependencies {
implementation(Libs.rxandroid)
implementation(Libs.rxjava2_debug)

// loading animation
implementation(Libs.spinKit)

implementation(Libs.serialization)
implementation(Libs.workRuntimeKtx)

implementation(Libs.lottie)
}
2 changes: 1 addition & 1 deletion sdk/src/main/assets/iamportcdn.html
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,6 @@

</script>
<script defer type="text/javascript" src="https://code.jquery.com/jquery-latest.min.js"></script>
<script defer type="text/javascript" src="https://cdn.iamport.kr/js/iamport.payment-1.2.0.js"></script>
<script defer type="text/javascript" src="https://cdn.iamport.kr/v1/iamport.js"></script>
</body>
</html>
2 changes: 1 addition & 1 deletion sdk/src/main/assets/mobileweb.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<!-- jQuery -->
<script defer type="text/javascript" src="https://code.jquery.com/jquery-latest.min.js"></script>
<!-- iamport.payment.js -->
<script defer type="text/javascript" src="https://cdn.iamport.kr/js/iamport.payment-1.2.0.js"></script>
<script defer type="text/javascript" src="https://cdn.iamport.kr/v1/iamport.js"></script>

<style type="text/css">
html, body, button {
Expand Down
3 changes: 3 additions & 0 deletions sdk/src/main/java/com/iamport/sdk/data/sdk/IamPortResponse.kt
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,12 @@ data class IamPortResponse(
val imp_success: Boolean? = false,
val success: Boolean? = false,
val imp_uid: String?,
val txId: String? = null,
val merchant_uid: String?,
val error_msg: String? = null,
val message: String? = null,
val error_code: String? = null,
val code: String? = null,
) : Parcelable {
companion object {
fun makeSuccess(payment: Payment, impUid: String? = null, msg: String): IamPortResponse {
Expand Down
6 changes: 3 additions & 3 deletions sdk/src/main/java/com/iamport/sdk/data/sdk/PG.kt
Original file line number Diff line number Diff line change
Expand Up @@ -35,19 +35,19 @@ enum class PG(val korName: String) {
payco("페이코"), eximbay("엑심베이"), settle("세틀뱅크"), settle_firm("세틀뱅크_펌"),
/*naverco("네이버페이-주문형"),*/ naverpay("네이버페이-결제형"), smilepay("스마일페이"),
payple("페이플"), alipay("알리페이"),
bluewalnut("bluewalnut"), tosspay("간편결제 - 토스"), smartro("스마트로"); /*, inicis("이니시스ActiveX결제창"), syrup("시럽페이");*/
bluewalnut("bluewalnut"), tosspay("간편결제 - 토스"), smartro("스마트로"), nice_v2("나이스페이 V2"); /*, inicis("이니시스ActiveX결제창"), syrup("시럽페이");*/

fun makePgRawName(pgId: String? = null): String {
return "${this.name}${if (!pgId.isNullOrBlank()) ".${pgId}" else CONST.EMPTY_STR}"
}

companion object {
fun convertPG(pgString: String): PG? {
return values().find { pgString == (it.name) }
return entries.find { pgString == (it.name) }
}

fun getPGNames(): List<String> {
return values().map { "${it.korName} (${it.name})" }.toList()
return entries.map { "${it.korName} (${it.name})" }.toList()
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import android.content.Intent
import android.net.Uri
import android.view.View
import android.webkit.WebView
import android.widget.ProgressBar
import com.airbnb.lottie.LottieAnimationView
import com.google.gson.GsonBuilder
import com.iamport.sdk.R
import com.iamport.sdk.data.sdk.IamPortResponse
Expand All @@ -28,7 +28,7 @@ class WebViewActivity : BaseActivity<WebViewModel>(), IamportKoinComponent {
override val layoutResourceId: Int = R.layout.webview_activity
override val viewModel: WebViewModel by viewModel()

private lateinit var loading: ProgressBar
private lateinit var loading: LottieAnimationView
private lateinit var webview: WebView
private var payment: Payment? = null

Expand Down
15 changes: 7 additions & 8 deletions sdk/src/main/res/layout/loading.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
<com.github.ybq.android.spinkit.SpinKitView xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:android="http://schemas.android.com/apk/res/android"
android:id="@+id/spin_kit"
style="@style/SpinKitView.Large.FadingCircle"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="center"
app:SpinKit_Color="#6066FF" />
<com.airbnb.lottie.LottieAnimationView
id="@+id/animationView"
layout_width="match_parent"
layout_height="wrap_content"
lottie_rawRes="@raw/animation"
lottie_autoPlay="true"
lottie_loop="true"/>
1 change: 1 addition & 0 deletions sdk/src/main/res/raw/animation.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"v":"4.6.8","fr":29.9700012207031,"ip":0,"op":119.000004846969,"w":256,"h":256,"nm":"Comp 1","ddd":0,"assets":[],"layers":[{"ddd":0,"ind":1,"ty":4,"nm":"Shape Layer 4","ks":{"o":{"a":0,"k":100},"r":{"a":0,"k":0},"p":{"a":0,"k":[128,128.016,0]},"a":{"a":0,"k":[13,13.016,0]},"s":{"a":0,"k":[100,100,100]}},"ao":0,"shapes":[{"ty":"gr","it":[{"d":1,"ty":"el","s":{"a":0,"k":[200,200]},"p":{"a":0,"k":[0,0]},"nm":"Ellipse Path 1","mn":"ADBE Vector Shape - Ellipse"},{"ty":"tm","s":{"a":1,"k":[{"i":{"x":[0.667],"y":[1]},"o":{"x":[0.333],"y":[0]},"n":["0p667_1_0p333_0"],"t":92,"s":[0],"e":[25]},{"i":{"x":[0.667],"y":[1]},"o":{"x":[0.333],"y":[0]},"n":["0p667_1_0p333_0"],"t":105,"s":[25],"e":[49]},{"i":{"x":[0.667],"y":[1]},"o":{"x":[0.333],"y":[0]},"n":["0p667_1_0p333_0"],"t":112,"s":[49],"e":[100]},{"t":120.0000048877}],"ix":1},"e":{"a":1,"k":[{"i":{"x":[0.667],"y":[1]},"o":{"x":[0.333],"y":[0]},"n":["0p667_1_0p333_0"],"t":90,"s":[1],"e":[100]},{"t":120.0000048877}],"ix":2},"o":{"a":0,"k":0,"ix":3},"m":1,"ix":2,"nm":"Trim Paths 1","mn":"ADBE Vector Filter - Trim"},{"ty":"st","c":{"a":0,"k":[0.023529,0.854902,0.238708,1]},"o":{"a":0,"k":100},"w":{"a":0,"k":20},"lc":2,"lj":1,"ml":4,"nm":"Stroke 1","mn":"ADBE Vector Graphic - Stroke"},{"ty":"tr","p":{"a":0,"k":[12,13],"ix":2},"a":{"a":0,"k":[0,0],"ix":1},"s":{"a":0,"k":[100,100],"ix":3},"r":{"a":0,"k":0,"ix":6},"o":{"a":0,"k":100,"ix":7},"sk":{"a":0,"k":0,"ix":4},"sa":{"a":0,"k":0,"ix":5},"nm":"Transform"}],"nm":"Ellipse 1","np":4,"cix":2,"ix":1,"mn":"ADBE Vector Group"}],"ip":90.0000036657751,"op":390.000015885026,"st":90.0000036657751,"bm":0,"sr":1},{"ddd":0,"ind":2,"ty":4,"nm":"Shape Layer 3","ks":{"o":{"a":0,"k":100},"r":{"a":0,"k":0},"p":{"a":0,"k":[128,128.016,0]},"a":{"a":0,"k":[13,13.016,0]},"s":{"a":0,"k":[100,100,100]}},"ao":0,"shapes":[{"ty":"gr","it":[{"d":1,"ty":"el","s":{"a":0,"k":[200,200]},"p":{"a":0,"k":[0,0]},"nm":"Ellipse Path 1","mn":"ADBE Vector Shape - Ellipse"},{"ty":"tm","s":{"a":1,"k":[{"i":{"x":[0.667],"y":[1]},"o":{"x":[0.333],"y":[0]},"n":["0p667_1_0p333_0"],"t":62,"s":[0],"e":[25]},{"i":{"x":[0.667],"y":[1]},"o":{"x":[0.333],"y":[0]},"n":["0p667_1_0p333_0"],"t":75,"s":[25],"e":[49]},{"i":{"x":[0.667],"y":[1]},"o":{"x":[0.333],"y":[0]},"n":["0p667_1_0p333_0"],"t":82,"s":[49],"e":[100]},{"t":90.0000036657751}],"ix":1},"e":{"a":1,"k":[{"i":{"x":[0.667],"y":[1]},"o":{"x":[0.333],"y":[0]},"n":["0p667_1_0p333_0"],"t":60,"s":[1],"e":[100]},{"t":90.0000036657751}],"ix":2},"o":{"a":0,"k":0,"ix":3},"m":1,"ix":2,"nm":"Trim Paths 1","mn":"ADBE Vector Filter - Trim"},{"ty":"st","c":{"a":0,"k":[0.854902,0.023529,0.2582694,1]},"o":{"a":0,"k":100},"w":{"a":0,"k":20},"lc":2,"lj":1,"ml":4,"nm":"Stroke 1","mn":"ADBE Vector Graphic - Stroke"},{"ty":"tr","p":{"a":0,"k":[12,13],"ix":2},"a":{"a":0,"k":[0,0],"ix":1},"s":{"a":0,"k":[100,100],"ix":3},"r":{"a":0,"k":0,"ix":6},"o":{"a":0,"k":100,"ix":7},"sk":{"a":0,"k":0,"ix":4},"sa":{"a":0,"k":0,"ix":5},"nm":"Transform"}],"nm":"Ellipse 1","np":4,"cix":2,"ix":1,"mn":"ADBE Vector Group"}],"ip":60.0000024438501,"op":360.000014663101,"st":60.0000024438501,"bm":0,"sr":1},{"ddd":0,"ind":3,"ty":4,"nm":"Shape Layer 2","ks":{"o":{"a":0,"k":100},"r":{"a":0,"k":0},"p":{"a":0,"k":[128,128.016,0]},"a":{"a":0,"k":[13,13.016,0]},"s":{"a":0,"k":[100,100,100]}},"ao":0,"shapes":[{"ty":"gr","it":[{"d":1,"ty":"el","s":{"a":0,"k":[200,200]},"p":{"a":0,"k":[0,0]},"nm":"Ellipse Path 1","mn":"ADBE Vector Shape - Ellipse"},{"ty":"tm","s":{"a":1,"k":[{"i":{"x":[0.667],"y":[1]},"o":{"x":[0.333],"y":[0]},"n":["0p667_1_0p333_0"],"t":32,"s":[0],"e":[25]},{"i":{"x":[0.667],"y":[1]},"o":{"x":[0.333],"y":[0]},"n":["0p667_1_0p333_0"],"t":45,"s":[25],"e":[49]},{"i":{"x":[0.667],"y":[1]},"o":{"x":[0.333],"y":[0]},"n":["0p667_1_0p333_0"],"t":52,"s":[49],"e":[100]},{"t":60.0000024438501}],"ix":1},"e":{"a":1,"k":[{"i":{"x":[0.667],"y":[1]},"o":{"x":[0.333],"y":[0]},"n":["0p667_1_0p333_0"],"t":30,"s":[1],"e":[100]},{"t":60.0000024438501}],"ix":2},"o":{"a":0,"k":0,"ix":3},"m":1,"ix":2,"nm":"Trim Paths 1","mn":"ADBE Vector Filter - Trim"},{"ty":"st","c":{"a":0,"k":[0.023529,0.6886272,0.854902,1]},"o":{"a":0,"k":100},"w":{"a":0,"k":20},"lc":2,"lj":1,"ml":4,"nm":"Stroke 1","mn":"ADBE Vector Graphic - Stroke"},{"ty":"tr","p":{"a":0,"k":[12,13],"ix":2},"a":{"a":0,"k":[0,0],"ix":1},"s":{"a":0,"k":[100,100],"ix":3},"r":{"a":0,"k":0,"ix":6},"o":{"a":0,"k":100,"ix":7},"sk":{"a":0,"k":0,"ix":4},"sa":{"a":0,"k":0,"ix":5},"nm":"Transform"}],"nm":"Ellipse 1","np":4,"cix":2,"ix":1,"mn":"ADBE Vector Group"}],"ip":30.0000012219251,"op":330.000013441176,"st":30.0000012219251,"bm":0,"sr":1},{"ddd":0,"ind":4,"ty":4,"nm":"Shape Layer 1","ks":{"o":{"a":0,"k":100},"r":{"a":0,"k":0},"p":{"a":0,"k":[128,128.016,0]},"a":{"a":0,"k":[13,13.016,0]},"s":{"a":0,"k":[100,100,100]}},"ao":0,"shapes":[{"ty":"gr","it":[{"d":1,"ty":"el","s":{"a":0,"k":[200,200]},"p":{"a":0,"k":[0,0]},"nm":"Ellipse Path 1","mn":"ADBE Vector Shape - Ellipse"},{"ty":"tm","s":{"a":1,"k":[{"i":{"x":[0.667],"y":[1]},"o":{"x":[0.333],"y":[0]},"n":["0p667_1_0p333_0"],"t":2,"s":[0],"e":[25]},{"i":{"x":[0.667],"y":[1]},"o":{"x":[0.333],"y":[0]},"n":["0p667_1_0p333_0"],"t":15,"s":[25],"e":[49]},{"i":{"x":[0.667],"y":[1]},"o":{"x":[0.333],"y":[0]},"n":["0p667_1_0p333_0"],"t":22,"s":[49],"e":[100]},{"t":30.0000012219251}],"ix":1},"e":{"a":1,"k":[{"i":{"x":[0.667],"y":[1]},"o":{"x":[0.333],"y":[0]},"n":["0p667_1_0p333_0"],"t":0,"s":[1],"e":[100]},{"t":30.0000012219251}],"ix":2},"o":{"a":0,"k":0,"ix":3},"m":1,"ix":2,"nm":"Trim Paths 1","mn":"ADBE Vector Filter - Trim"},{"ty":"st","c":{"a":0,"k":[0.854902,0.54902,0.023529,1]},"o":{"a":0,"k":100},"w":{"a":0,"k":20},"lc":2,"lj":1,"ml":4,"nm":"Stroke 1","mn":"ADBE Vector Graphic - Stroke"},{"ty":"tr","p":{"a":0,"k":[12,13],"ix":2},"a":{"a":0,"k":[0,0],"ix":1},"s":{"a":0,"k":[100,100],"ix":3},"r":{"a":0,"k":0,"ix":6},"o":{"a":0,"k":100,"ix":7},"sk":{"a":0,"k":0,"ix":4},"sa":{"a":0,"k":0,"ix":5},"nm":"Transform"}],"nm":"Ellipse 1","np":4,"cix":2,"ix":1,"mn":"ADBE Vector Group"}],"ip":0,"op":300.00001221925,"st":0,"bm":0,"sr":1}]}
13 changes: 13 additions & 0 deletions settings.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,3 +1,16 @@
dependencyResolutionManagement {
repositoriesMode.set(RepositoriesMode.FAIL_ON_PROJECT_REPOS)
repositories {
flatDir {
dirs("libs")
}
google()
mavenCentral()
gradlePluginPortal()
maven { setUrl("https://jitpack.io") }
}
}

rootProject.name = "AndroidSdk"
include(":sdk")
include(":app")

0 comments on commit e802d12

Please sign in to comment.