Skip to content

IBX-8753: Improved ModifyFieldDefinitions logic #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: 4.6
Choose a base branch
from
Open

IBX-8753: Improved ModifyFieldDefinitions logic #1614

wants to merge 7 commits into from

Conversation

tbialcz
Copy link
Contributor

@tbialcz tbialcz commented Jun 30, 2025 •
edited
Loading

🎫 Issue IBX-8753

Description:

This PR extends the ModifyFieldDefinitionFieldsSubscriber to support the following:

  • Applying field modifications conditionally based on a provided SpecificationInterface.
  • Keeping backward compatibility by accepting both string and string[] in the constructor.
  • Updated logic in onPreSetData to check the provided SpecificationInterface against the content type being edited.

For QA:

Documentation:

@tbialcz tbialcz requested a review from adamwojs June 30, 2025 09:30
@tbialcz tbialcz force-pushed the ibx_8753 branch 2 times, most recently from dcccc72 to 9a1427b Compare June 30, 2025 11:49
adamwojs
adamwojs reviewed Jul 1, 2025
View reviewed changes
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 but we need to improve code readability. I think we can start by splitting onPreSetData logic into several small private methods: https://gist.github.com/adamwojs/e1934ded9bceb3eb92d1f7b8f5c23fdc

@tbialcz tbialcz changed the title IBX-8753: Added ContentTypeIsCompany specification and improved ModifyFieldDefinitions logic IBX-8753: Improved ModifyFieldDefinitions logic Jul 2, 2025
@tbialcz tbialcz requested review from adamwojs and a team July 2, 2025 08:56
@ezrobot ezrobot requested review from mikadamczyk, Steveb-p, alongosz, ciastektk, ViniTou, barw4, wiewiurdp and konradoboza and removed request for a team July 2, 2025 08:57
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tbialcz tbialcz requested a review from Steveb-p August 22, 2025 09:33
konradoboza
konradoboza requested changes Aug 25, 2025
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We go away from relying on magic getters:

@tbialcz tbialcz requested a review from konradoboza August 25, 2025 07:55
@tbialcz @pawlakadrian
IBX-8753: Added ContentTypeIsCompany specification and improved Modif…
51fa904 
…yFieldDefinitions logic
@tbialcz @pawlakadrian
IBX-9876: Removed ContentTypeIsCompany specification and related serv…
7fd886a 
…ice definitions
@tbialcz @pawlakadrian
IBX-8753: Refactored ModifyFieldDefinitionFieldsSubscriber to improve…
64cfeef 
… readability and encapsulate logic with helper methods
@tbialcz @pawlakadrian
IBX-8753: Replaced SpecificationInterface with CorporateAccount depen…
60cf904 
…dency and updated related logic
@tbialcz @pawlakadrian
IBX-8753: Replaced CorporateAccount dependency with SpecificationInte…
7467d16 
…rface and updated related logic
@tbialcz @pawlakadrian
IBX-8753: Refactor fieldIdentifiers parameter to enforce array type i…
50a68bf 
…n ModifyFieldDefinitionFieldsSubscriber and ModifyFieldDefinitionsCollectionTypeExtension constructors
@tbialcz @pawlakadrian
Fixed method call to getFieldTypeIdentifier in acceptsFieldDefinition…
2d6c9d0 
… for improved clarity
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pawlakadrian pawlakadrian self-requested a review September 2, 2025 10:08
pawlakadrian
pawlakadrian approved these changes Sep 2, 2025
View reviewed changes
Copy link

@pawlakadrian pawlakadrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on DXP Commerce 4.6.x-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@pawlakadrian pawlakadrian pawlakadrian approved these changes

@konradoboza konradoboza konradoboza approved these changes

@alongosz alongosz Awaiting requested review from alongosz

@ciastektk ciastektk Awaiting requested review from ciastektk

@ViniTou ViniTou Awaiting requested review from ViniTou

@barw4 barw4 Awaiting requested review from barw4

@wiewiurdp wiewiurdp Awaiting requested review from wiewiurdp

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

Assignees

@mikadamczyk mikadamczyk

@ciastektk ciastektk

@ViniTou ViniTou

Labels
QA approved Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tbialcz @adamwojs @mikadamczyk @Steveb-p @pawlakadrian @ViniTou @konradoboza @ciastektk