-
Notifications
You must be signed in to change notification settings - Fork 18
IBX-9674: Fixed value coverage by action btns #1626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces a static SCSS offset for number input action buttons with dynamic JavaScript padding logic and standardizes spacing constants.
- Removed hard-coded right offset for number input actions in SCSS
- Added JS logic to dynamically adjust padding on number inputs based on value presence
- Renamed
TEXTAREA_SCROLLBAR_PADDING
constant toEXTRA_SPACING
and applied it consistently
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/bundle/Resources/public/scss/_inputs.scss | Removed the static .ibexa-input-text-wrapper__actions offset under --type-number |
src/bundle/Resources/public/js/scripts/admin.input.text.js | Introduced dynamic padding adjustments for number inputs, renamed padding constant |
Comments suppressed due to low confidence (2)
src/bundle/Resources/public/js/scripts/admin.input.text.js:3
- [nitpick] The constant name
EXTRA_SPACING
is vague; consider using a more descriptive name (e.g.,ACTION_BUTTON_SPACING
orSCROLLBAR_PADDING
) to clarify its purpose.
const EXTRA_SPACING = 6;
src/bundle/Resources/public/js/scripts/admin.input.text.js:56
- Consider adding automated tests to cover the new number input padding logic branch, ensuring proper padding is applied when the field has a value and when it is empty.
if (input.type === 'number') {
|
Description:
For QA:
Documentation: