IBX: 11010 improve anchor links switcher #1805
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alekmick
changed the title
ibexa-workflow-automation-1
bot
requested review from
GrabowskiM,
OstafinL,
albozek,
dew326 and
tischsoic
and removed request for
a team
GrabowskiM
requested changes
Dec 18, 2025
|
|
||
| const header = doc.querySelector('.ibexa-edit-header'); | ||
| const headerContainer = header?.querySelector('.ibexa-edit-header__container'); | ||
| const anchorNavigationSwitcher = doc.querySelector('.ibexa-tabs--switcher'); |
Contributor
There was a problem hiding this comment.
Suggested change
| const anchorNavigationSwitcher = doc.querySelector('.ibexa-tabs--switcher'); | |
| const anchorNavigationSwitcher = doc.querySelector('.ibexa-anchor-navigation .ibexa-tabs--switcher'); |
for safety, .ibexa-tabs--switcher can be used in other contexts as well
| const headerBottomContainerHeight = header.offsetHeight - headerContainer?.offsetHeight; | ||
|
|
||
| return top + height >= headerContainer?.offsetHeight + headerBottomContainerHeight + SECTION_ADJUST_MARGIN_TOP; | ||
| const anchorNavigationSwitcherHeight = anchorNavigationSwitcher?.offsetHeight || 0; |
Contributor
There was a problem hiding this comment.
Suggested change
| const anchorNavigationSwitcherHeight = anchorNavigationSwitcher?.offsetHeight || 0; | |
| const anchorNavigationSwitcherHeight = anchorNavigationSwitcher?.offsetHeight ?? 0; |
| border-top: calculateRem(1px) solid $ibexa-color-light; | ||
| position: absolute; | ||
| right: calculateRem(30px); | ||
| z-index: 1; |
Contributor
There was a problem hiding this comment.
personally I would use at least sth like z-index 10 to leave possibility to add sth between 0 and &__sections
| color: $ibexa-color-dark-400; | ||
| align-items: center; | ||
| font-weight: 600; | ||
| border-left: 1px solid $ibexa-color-light; |
Contributor
There was a problem hiding this comment.
Suggested change
| border-left: 1px solid $ibexa-color-light; | |
| border-left: calculateRem(1px) solid $ibexa-color-light; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For QA:
Documentation: