Fixed ruleset versioning #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steveb-p
approved these changes
Oct 9, 2025
ciastektk
approved these changes
Oct 9, 2025
tbialcz
approved these changes
Oct 9, 2025
konradoboza
approved these changes
Oct 9, 2025
Co-authored-by: Paweł Niedzielski <[email protected]>
Co-authored-by: Konrad Oboza <[email protected]>
|
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Even though new rules were added to the 5.0 set, the 4.6 ruleset was still used by default every time. This solution centralizes the ruleset configuration and establishes a clear link, so there’s no need to modify
.php-cs-fixer.phpwhenever a new one is introduced.However, in most cases, this package is probably still used as a
~2.0.0dependency instead of~2.1, or perhaps even something more recent. Therefore, it still needs to be bumped across repositories.Apart from that, the package also needs to be released - opting for version 2.1.1 to avoid complications if some packages are already at 2.1.
For QA:
Documentation: