-
Notifications
You must be signed in to change notification settings - Fork 0
IBX-10471: [Inputs] Inputs Validators Base #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ffa8a2c
IBX-10471: [Inputs] Inputs Validators Base
GrabowskiM 6f65e4d
copilot suggestion fixes
GrabowskiM 2d26957
redo validators
GrabowskiM f31e969
after CR
GrabowskiM 670a18f
linter
GrabowskiM da56241
removed _
GrabowskiM File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import BaseValidator from '../../validators/BaseValidator'; | ||
|
||
export interface ValidationResult { | ||
isValid: boolean; | ||
messages: string[]; | ||
} | ||
|
||
export const validateInput = <T>(value: T, validators: BaseValidator<T>[]): ValidationResult => { | ||
const errors = validators.reduce((errorsAcc: string[], validator) => { | ||
if (!validator.validate(value)) { | ||
return [...errorsAcc, validator.getErrorMessage()]; | ||
} | ||
|
||
return errorsAcc; | ||
}, []); | ||
|
||
return { isValid: !errors.length, messages: errors }; | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { TranslatorType } from '@ids-context/Translator'; | ||
|
||
export default abstract class BaseValidator<T> { | ||
protected _translator: TranslatorType; | ||
|
||
constructor(translator: TranslatorType) { | ||
this._translator = translator; | ||
} | ||
|
||
abstract getErrorMessage(): string; | ||
|
||
abstract validate(value: T): boolean; | ||
} |
13 changes: 13 additions & 0 deletions
13
packages/components/src/validators/IsEmptyStringValidator.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import BaseValidator from './BaseValidator'; | ||
|
||
export default class IsEmptyStringValidator extends BaseValidator<string> { | ||
getErrorMessage(): string { | ||
const Translator = this._translator; | ||
|
||
return Translator.trans(/*@Desc("This field cannot be empty.")*/ 'ibexa.validators.is_empty_string'); | ||
} | ||
|
||
validate(value: string): boolean { | ||
return value.trim() !== ''; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.