IBX-7999: Checkbox and ThreeStateCheckbox #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements checkbox components by introducing a basic Checkbox component and a ThreeStateCheckbox component that extends it with indeterminate state support. The implementation includes proper styling, ref forwarding, and comprehensive Storybook documentation.
- Added
Checkboxcomponent with standard checkbox functionality and proper event handling - Added
ThreeStateCheckboxcomponent that extends Checkbox to support indeterminate state - Enhanced
BaseInputcomponent to support ref forwarding for the new checkbox implementations
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/components/src/internal/partials/BaseInput/BaseInput.types.ts | Added Ref type import and ref prop to support forwarding refs to input elements |
| packages/components/src/internal/partials/BaseInput/BaseInput.tsx | Added ref prop handling to forward refs to the underlying input element |
| packages/components/src/inputs/Checkbox/*.tsx | Implemented basic Checkbox component with proper event handling and styling |
| packages/components/src/inputs/ThreeStateCheckbox/*.tsx | Implemented ThreeStateCheckbox extending Checkbox with indeterminate state support |
| packages/assets/src/scss/inputs/_checkbox.scss | Added comprehensive CSS styling for checkbox states including indeterminate |
| packages/assets/src/scss/styles.scss | Imported checkbox styles into the main stylesheet |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/components/src/inputs/ThreeStateCheckbox/ThreeStateCheckbox.tsx
Outdated
Show resolved
Hide resolved
albozek
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For QA:
Documentation: