IBX-10307: Form Control - Input Text #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a Form Control wrapper for Input Text components, implementing a reusable base form control structure with label and helper text functionality.
Key changes:
- New BaseFormControl component providing consistent form field layout with label and helper text support
- FormControlInputText component that wraps basic InputText with validation and form control features
- Enhanced validation system with automatic required field validation
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/components/src/internal/partials/BaseFormControl/* | New base form control component providing consistent layout structure |
| packages/components/src/internal/hooks/useValidatorManager.ts | Added default generic type parameter for better type safety |
| packages/components/src/formControls/InputText/* | New form control wrapper for InputText with validation and structured layout |
| packages/components/src/inputs/InputText/InputText.test.stories.tsx | Added value assertion to existing test |
| packages/assets/src/scss/* | Added form control styles and reorganized imports |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tischsoic
reviewed
Aug 19, 2025
GrabowskiM
force-pushed
the
IBX-10307-v3
branch
from
648268d to
a67cd76
Compare
GrabowskiM
force-pushed
the
IBX-10307-v3
branch
from
bb5f93c to
4014b12
Compare
GrabowskiM
requested review from
tischsoic,
dew326,
OstafinL,
RopRaptor and
albozek
OstafinL
approved these changes
Aug 28, 2025
albozek
approved these changes
Aug 28, 2025
dew326
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For QA:
Documentation: