-
Notifications
You must be signed in to change notification settings - Fork 84
IBX-9147: Symbol attribute type described in Developer Documentation - v4.6 #2525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.6
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for preparing this!
I've left a couple of suggestions to make it clearer - but I believe it already includes all the neccessary parts, we just need to improve them a bit.
I cannot provide you with the PostgreSQL schema, we will need someone from the backend team for that.
I will take care of it. |
9685412
to
2bc62c6
Compare
Preview of modified filesPreview of modified Markdown: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just a couple of comments to improve this.
Please remember to create a PR to the user doc, mentioning this attribute (just a mention is ok, we did the same for date and time: https://doc.ibexa.co/projects/userguide/en/latest/pim/work_with_product_attributes/ )
Also, please have a look at the read the docs error - I think we (I) have lost the mkdocs.yml modification during conflict resolution, could you please readd the symbolattribute_criterion.md
file to make the build pass?
Another thing which I forgot about: please add the new LTS update to the table of LTS updates (https://github.com/ibexa/documentation-developer/blob/4.6/docs/ibexa_products/editions.md#lts-updates) |
Symbol attribute type described in Developer Documentation - v4.6
Preview:
Checklist