Skip to content

IBX-9147: Symbol attribute type described in Developer Documentation - v4.6 #2525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: 4.6
Choose a base branch
from

Conversation

julitafalcondusza
Copy link
Contributor

@julitafalcondusza julitafalcondusza commented Oct 24, 2024

Question Answer
JIRA Ticket (https://issues.ibexa.co/browse/IBX-9147)
Versions 4.6+

Symbol attribute type described in Developer Documentation - v4.6

Preview:

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for preparing this!

I've left a couple of suggestions to make it clearer - but I believe it already includes all the neccessary parts, we just need to improve them a bit.

I cannot provide you with the PostgreSQL schema, we will need someone from the backend team for that.

@adamwojs
Copy link
Member

I cannot provide you with the PostgreSQL schema, we will need someone from the backend team for that.

I will take care of it.

@mnocon mnocon changed the base branch from master to 5.0 May 19, 2025 07:33
@julitafalcondusza julitafalcondusza changed the base branch from 5.0 to 4.6 July 9, 2025 09:27
@julitafalcondusza julitafalcondusza marked this pull request as ready for review July 9, 2025 11:09
@julitafalcondusza julitafalcondusza requested a review from mnocon July 9, 2025 11:09
Copy link

github-actions bot commented Jul 9, 2025

Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a couple of comments to improve this.

Please remember to create a PR to the user doc, mentioning this attribute (just a mention is ok, we did the same for date and time: https://doc.ibexa.co/projects/userguide/en/latest/pim/work_with_product_attributes/ )

Also, please have a look at the read the docs error - I think we (I) have lost the mkdocs.yml modification during conflict resolution, could you please readd the symbolattribute_criterion.md file to make the build pass?

@julitafalcondusza julitafalcondusza requested a review from mnocon July 15, 2025 06:17
@julitafalcondusza julitafalcondusza changed the title IBX-9147: Symbol attribute type described in Developer Documentation IBX-9147: Symbol attribute type described in Developer Documentation - v4.6 Jul 15, 2025
@mnocon
Copy link
Contributor

mnocon commented Jul 15, 2025

Another thing which I forgot about: please add the new LTS update to the table of LTS updates (https://github.com/ibexa/documentation-developer/blob/4.6/docs/ibexa_products/editions.md#lts-updates)

@julitafalcondusza julitafalcondusza requested a review from mnocon July 16, 2025 10:21
@julitafalcondusza julitafalcondusza added Wait with merge PRs that shouldn't be merged instantly and removed Needs DOC review labels Jul 17, 2025
@mnocon mnocon mentioned this pull request Jul 17, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Wait with merge PRs that shouldn't be merged instantly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants