Skip to content

Twig Component follow ups #2792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: 4.6
Choose a base branch
from
Open

Twig Component follow ups #2792

wants to merge 4 commits into from

Conversation

mnocon
Copy link
Contributor

@mnocon mnocon commented Jun 17, 2025 •
edited
Loading

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 17, 2025 •
edited
Loading

Preview of modified files

Preview of modified Markdown:

@mnocon mnocon requested a review from wiewiurdp July 3, 2025 12:50
wiewiurdp
wiewiurdp requested changes Jul 10, 2025
View reviewed changes
docs/templating/layout/customize_storefront_layout.md Outdated
| `storefront-after-maincart` | `vendor/ibexa/storefront/src/bundle/Resources/views/themes/storefront/cart/component/maincart/maincart.html.twig` |
| `storefront-before-minicart` | `vendor/ibexa/storefront/src/bundle/Resources/views/themes/storefront/cart/component/minicart/minicart.html.twig` |
| `storefront-after-minicart` | `vendor/ibexa/storefront/src/bundle/Resources/views/themes/storefront/cart/component/minicart/minicart.html.twig` |
| `storefront-before-add-to-cart` | `vendor/ibexa/cart/src/bundle/Resources/views/themes/standard/cart/component/add_to_cart/add_to_cart.html.twig` |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There would be a small change

storefront-before-add-to-cart
storefront-after-add-to-cart
storefront-before-summary
storefront-after-summary

these would be used in different templates see following PR
https://github.com/ibexa/storefront/pull/236

@mnocon
Copy link
Contributor Author

mnocon commented Jul 10, 2025 •
edited
Loading

Thank you @wiewiurdp , paths adjusted in bef9c6d

@mnocon mnocon requested a review from wiewiurdp July 10, 2025 13:49
@mnocon mnocon requested a review from a team July 15, 2025 09:31
@ezrobot ezrobot requested review from adriendupuis, dabrt and julitafalcondusza and removed request for a team July 15, 2025 09:31
julitafalcondusza
julitafalcondusza approved these changes Jul 16, 2025
View reviewed changes
@mnocon mnocon added Wait with merge PRs that shouldn't be merged instantly Ready for MERGE and removed Needs DOC review labels Jul 16, 2025
@github-actions GitHub Actions
Copy link

code_samples/ change report

Before (on target branch)After (in current PR)

code_samples/back_office/components/twig_components.yaml


code_samples/back_office/components/twig_components.yaml

docs/templating/components.md@69:``` yaml
docs/templating/components.md@70:[[= include_file('code_samples/back_office/components/twig_components.yaml') =]]
docs/templating/components.md@71:```
docs/templating/components.md@73:``` yaml
docs/templating/components.md@74:[[= include_file('code_samples/back_office/components/twig_components.yaml') =]]
docs/templating/components.md@75:```

001⫶ibexa_twig_components:
002⫶    admin-ui-user-menu:
003⫶        custom-html-component:
004⫶            type: html

001⫶ibexa_twig_components:
002⫶    admin-ui-user-menu:
003⫶        custom-html-component:
004⫶            type: html
005⫶            arguments:
006⫶                content: '<b>Hello world!</b>'
007⫶        custom-template-component:
008⫶            type: template
009⫶            arguments:
010⫶                template: '@ibexadesign/ui/component/user_thumbnail/user_thumbnail.html.twig'
011⫶                parameters:
012⫶                    user_content:
013⫶                        name: "Thumbnail"
014⫶                        thumbnail:
015⫶                            resource: https://placecats.com/100/100
016⫶        custom-controller-component:
017⫶            type: controller
018⫶            arguments:
019⫶                controller: '\App\Controller\MyController::requestAction'
020⫶                parameters:
021⫶                    parameter1: 'custom'
022⫶                    parameter2: true
023⫶    admin-ui-stylesheet-head:
024⫶        custom-link-component:
025⫶            type: stylesheet
026⫶            arguments:
027⫶                href: 'https://fonts.googleapis.com/css?family=Roboto:300,300i,400,400i,700,700i%7CRoboto+Mono:400,400i,700,700i&display=fallback'
028⫶                rel: stylesheet
029⫶                crossorigin: anonymous
030⫶                integrity: sha384-LN/mLhO/GN6Ge8ZPvI7uRsZpiXmtSkep+aFlJcHa8by4TvA34o1am9sa88eUzKTD
031⫶                type: text/css
032⫶    admin-ui-script-head:
033⫶        custom-script-component:
034⫶            type: script
035⫶            arguments:
036⫶                src: 'https://doc.ibexa.co/en/latest/js/custom.js'
037⫶                crossorigin: anonymous
038⫶                defer: false
039⫶                async: true
040⫶                integrity: sha384-Ewi2bBDtPbbu4/+fs8sIbBJ3zVl0LDOSznfhFR/JBK+SzggdRdX8XQKauWmI9HH2
041⫶                type: text/javascript
005⫶            priority: 0
006⫶            arguments:
007⫶                content: '<b>Hello world!</b>'
008⫶        custom-template-component:
009⫶            type: template
010⫶            priority: 50
011⫶            arguments:
012⫶                template: '@ibexadesign/ui/component/user_thumbnail/user_thumbnail.html.twig'
013⫶                parameters:
014⫶                    user_content:
015⫶                        name: "Thumbnail"
016⫶                        thumbnail:
017⫶                            resource: https://placecats.com/100/100
018⫶        custom-controller-component:
019⫶            type: controller
020⫶            arguments:
021⫶                controller: '\App\Controller\MyController::requestAction'
022⫶                parameters:
023⫶                    parameter1: 'custom'
024⫶                    parameter2: true
025⫶    admin-ui-stylesheet-head:
026⫶        custom-link-component:
027⫶            type: stylesheet
028⫶            arguments:
029⫶                href: 'https://fonts.googleapis.com/css?family=Roboto:300,300i,400,400i,700,700i%7CRoboto+Mono:400,400i,700,700i&display=fallback'
030⫶                rel: stylesheet
031⫶                crossorigin: anonymous
032⫶                integrity: sha384-LN/mLhO/GN6Ge8ZPvI7uRsZpiXmtSkep+aFlJcHa8by4TvA34o1am9sa88eUzKTD
033⫶                type: text/css
034⫶    admin-ui-script-head:
035⫶        custom-script-component:
036⫶            type: script
037⫶            arguments:
038⫶                src: 'https://doc.ibexa.co/en/latest/js/custom.js'
039⫶                crossorigin: anonymous
040⫶                defer: false
041⫶                async: true
042⫶                integrity: sha384-Ewi2bBDtPbbu4/+fs8sIbBJ3zVl0LDOSznfhFR/JBK+SzggdRdX8XQKauWmI9HH2
043⫶                type: text/javascript


 Download colorized diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiewiurdp wiewiurdp wiewiurdp approved these changes

@julitafalcondusza julitafalcondusza julitafalcondusza approved these changes

@adriendupuis adriendupuis Awaiting requested review from adriendupuis

@dabrt dabrt Awaiting requested review from dabrt

Assignees
No one assigned
Labels
Ready for MERGE Wait with merge PRs that shouldn't be merged instantly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnocon @wiewiurdp @julitafalcondusza