Discounts 4.6.22 #2810

mnocon · 2025-07-02T15:54:47Z

Documentation for:

Discount priority:
https://github.com/ibexa/discounts/pull/266
https://github.com/ibexa/discounts-codes/pull/30
https://github.com/ibexa/installer/pull/183

Discount code migrations:
https://github.com/ibexa/discounts-codes/pull/28

Global discount codes:
https://github.com/ibexa/discounts-codes/pull/20

Mention about the TODOs:

We don't have the PHP API Reference classes for the new introduced concepts, I will have to add the links once the release is out and the API Ref is regenerated
The draft of release notes doesn't contain all the information yet

I'll wait with merging this PR until 4.6.22 is out.

github-actions · 2025-07-02T16:01:48Z

Preview of modified files

Preview of modified Markdown:

code_samples/discounts/src/Command/ManageDiscountsCommand.php

code_samples/data_migration/examples/discounts/discount_code_create.yaml

docs/update_and_migration/from_4.6/update_from_4.6.md

docs/release_notes/ibexa_dxp_v4.6.md

mnocon · 2025-07-03T10:07:46Z

Thank you @adriendupuis , review suggestions applied in a35c98c

adriendupuis · 2025-07-09T15:29:56Z

docs/update_and_migration/from_4.6/update_from_4.6.md

@@ -391,16 +395,16 @@ To use the [latest features](ibexa_dxp_v4.6.md) added to them, update them separ

    Then apply manually the changes described below.

-    ## 4.6.20
+    ### Discounts 4.6.20


It disturb me to not have the 'v' on those ones contrary to the rest of the ToC above.

Suggested change

### Discounts 4.6.20

### Discounts v4.6.20

Good point, applied both of them in f1c9618

adriendupuis · 2025-07-09T15:30:22Z

docs/update_and_migration/from_4.6/update_from_4.6.md

@@ -522,6 +526,28 @@ To use the [latest features](ibexa_dxp_v4.6.md) added to them, update them separ
                REFERENCES ezuser (contentobject_id) ON UPDATE CASCADE ON DELETE CASCADE NOT DEFERRABLE INITIALLY IMMEDIATE;
        ```

+    ### Discounts 4.6.22


Suggested change

### Discounts 4.6.22

### Discounts v4.6.22

docs/update_and_migration/from_4.6/update_from_4.6.md

Co-authored-by: Konrad Oboza <[email protected]>

github-actions · 2025-07-24T12:59:03Z

code_samples/ change report

Before (on target branch)	After (in current PR)
`code_samples/data_migration/examples/discounts/discount_code_create.yaml`	`code_samples/data_migration/examples/discounts/discount_code_create.yaml`
	docs/content_management/data_migration/importing_data.md@533:``` yaml `docs/content_management/data_migration/importing_data.md@534:[[= include_file('code_samples/data_migration/examples/discounts/discount_code_create.yaml') =]]` docs/content_management/data_migration/importing_data.md@535:``` `001⫶type: discount_code` `002⫶mode: create` `003⫶code: summer10` `004⫶global_usage_limit: 100 # Optional` `005⫶user_usage_limit: 5 # Optional` `006⫶created_at: '2023-01-01T12:00:00+00:00' # Optional` `007⫶creator_id: 42 # Optional`
`code_samples/discounts/src/Command/ManageDiscountsCommand.php`	`code_samples/discounts/src/Command/ManageDiscountsCommand.php`
docs/discounts/discounts_api.md@118:``` php hl_lines="60-66 68-92"	docs/discounts/discounts_api.md@118:``` php hl_lines="60-67 69-97"
`docs/discounts/discounts_api.md@119:[[= include_file('code_samples/discounts/src/Command/ManageDiscountsCommand.php') =]]` docs/discounts/discounts_api.md@120:``` `001⫶<?php` `002⫶` `003⫶declare(strict_types=1);` `004⫶` `005⫶namespace App\Command;` `006⫶` `007⫶use DateTimeImmutable;` `008⫶use Ibexa\Contracts\Core\Collection\ArrayMap;` `009⫶use Ibexa\Contracts\Core\Repository\PermissionResolver;` `010⫶use Ibexa\Contracts\Core\Repository\UserService;` `011⫶use Ibexa\Contracts\Discounts\DiscountServiceInterface;` `012⫶use Ibexa\Contracts\Discounts\Value\DiscountType;` `013⫶use Ibexa\Contracts\Discounts\Value\Struct\DiscountCreateStruct;` `014⫶use Ibexa\Contracts\Discounts\Value\Struct\DiscountTranslationStruct;` `015⫶use Ibexa\Contracts\DiscountsCodes\DiscountCodeServiceInterface;` `016⫶use Ibexa\Contracts\DiscountsCodes\Value\Struct\DiscountCodeCreateStruct;` `017⫶use Ibexa\Discounts\Value\DiscountCondition\IsInCurrency;` `018⫶use Ibexa\Discounts\Value\DiscountCondition\IsInRegions;` `019⫶use Ibexa\Discounts\Value\DiscountCondition\IsProductInArray;` `020⫶use Ibexa\Discounts\Value\DiscountRule\FixedAmount;` `021⫶use Ibexa\DiscountsCodes\Value\DiscountCondition\IsValidDiscountCode;` `022⫶use Symfony\Component\Console\Command\Command;` `023⫶use Symfony\Component\Console\Input\InputInterface;` `024⫶use Symfony\Component\Console\Output\OutputInterface;` `025⫶` `026⫶final class ManageDiscountsCommand extends Command` `027⫶{` `028⫶ protected static $defaultName = 'discounts:manage';` `029⫶` `030⫶ private DiscountServiceInterface $discountService;` `031⫶` `032⫶ private DiscountCodeServiceInterface $discountCodeService;` `033⫶` `034⫶ private PermissionResolver $permissionResolver;` `035⫶` `036⫶ private UserService $userService;` `037⫶` `038⫶ public function __construct(` `039⫶ UserService $userSerice,` `040⫶ PermissionResolver $permissionResolver,` `041⫶ DiscountServiceInterface $discountService,` `042⫶ DiscountCodeServiceInterface $discountCodeService` `043⫶ ) {` `044⫶ $this->userService = $userSerice;` `045⫶ $this->discountService = $discountService;` `046⫶ $this->discountCodeService = $discountCodeService;` `047⫶ $this->permissionResolver = $permissionResolver;` `048⫶` `049⫶ parent::__construct();` `050⫶ }` `051⫶` `052⫶ protected function execute(InputInterface $input, OutputInterface $output): int` `053⫶ {` `054⫶ $this->permissionResolver->setCurrentUserReference(` `055⫶ $this->userService->loadUserByLogin('admin')` `056⫶ );` `057⫶` `058⫶ $now = new DateTimeImmutable();` `059⫶` `060❇️ $discountCodeCreateStruct = new DiscountCodeCreateStruct(` `061❇️ 'summer10',`	`docs/discounts/discounts_api.md@119:[[= include_file('code_samples/discounts/src/Command/ManageDiscountsCommand.php') =]]` docs/discounts/discounts_api.md@120:``` `001⫶<?php` `002⫶` `003⫶declare(strict_types=1);` `004⫶` `005⫶namespace App\Command;` `006⫶` `007⫶use DateTimeImmutable;` `008⫶use Ibexa\Contracts\Core\Collection\ArrayMap;` `009⫶use Ibexa\Contracts\Core\Repository\PermissionResolver;` `010⫶use Ibexa\Contracts\Core\Repository\UserService;` `011⫶use Ibexa\Contracts\Discounts\DiscountServiceInterface;` `012⫶use Ibexa\Contracts\Discounts\Value\DiscountType;` `013⫶use Ibexa\Contracts\Discounts\Value\Struct\DiscountCreateStruct;` `014⫶use Ibexa\Contracts\Discounts\Value\Struct\DiscountTranslationStruct;` `015⫶use Ibexa\Contracts\DiscountsCodes\DiscountCodeServiceInterface;` `016⫶use Ibexa\Contracts\DiscountsCodes\Value\Struct\DiscountCodeCreateStruct;` `017⫶use Ibexa\Discounts\Value\DiscountCondition\IsInCurrency;` `018⫶use Ibexa\Discounts\Value\DiscountCondition\IsInRegions;` `019⫶use Ibexa\Discounts\Value\DiscountCondition\IsProductInArray;` `020⫶use Ibexa\Discounts\Value\DiscountRule\FixedAmount;` `021⫶use Ibexa\DiscountsCodes\Value\DiscountCondition\IsValidDiscountCode;` `022⫶use Symfony\Component\Console\Command\Command;` `023⫶use Symfony\Component\Console\Input\InputInterface;` `024⫶use Symfony\Component\Console\Output\OutputInterface;` `025⫶` `026⫶final class ManageDiscountsCommand extends Command` `027⫶{` `028⫶ protected static $defaultName = 'discounts:manage';` `029⫶` `030⫶ private DiscountServiceInterface $discountService;` `031⫶` `032⫶ private DiscountCodeServiceInterface $discountCodeService;` `033⫶` `034⫶ private PermissionResolver $permissionResolver;` `035⫶` `036⫶ private UserService $userService;` `037⫶` `038⫶ public function __construct(` `039⫶ UserService $userSerice,` `040⫶ PermissionResolver $permissionResolver,` `041⫶ DiscountServiceInterface $discountService,` `042⫶ DiscountCodeServiceInterface $discountCodeService` `043⫶ ) {` `044⫶ $this->userService = $userSerice;` `045⫶ $this->discountService = $discountService;` `046⫶ $this->discountCodeService = $discountCodeService;` `047⫶ $this->permissionResolver = $permissionResolver;` `048⫶` `049⫶ parent::__construct();` `050⫶ }` `051⫶` `052⫶ protected function execute(InputInterface $input, OutputInterface $output): int` `053⫶ {` `054⫶ $this->permissionResolver->setCurrentUserReference(` `055⫶ $this->userService->loadUserByLogin('admin')` `056⫶ );` `057⫶` `058⫶ $now = new DateTimeImmutable();` `059⫶` `060❇️ $discountCodeCreateStruct = new DiscountCodeCreateStruct(` `061❇️ 'summer10',`
`062❇️ null, // Unlimited usage` `063❇️ $this->permissionResolver->getCurrentUserReference()->getUserId(),` `064❇️ $now` `065❇️ );` `066❇️ $discountCode = $this->discountCodeService->createDiscountCode($discountCodeCreateStruct);` `067⫶` `068❇️ $discountCreateStruct = new DiscountCreateStruct();` `069❇️ $discountCreateStruct` `070❇️ ->setIdentifier('discount_identifier')` `071❇️ ->setType(DiscountType::CART)` `072❇️ ->setPriority(10)` `073❇️ ->setEnabled(true)` `074❇️ ->setUser($this->userService->loadUserByLogin('admin'))` `075❇️ ->setRule(new FixedAmount(10))` `076❇️ ->setStartDate($now)` `077❇️ ->setConditions([` `078❇️ new IsInRegions(['germany', 'france']),` `079❇️ new IsProductInArray(['product-1', 'product-2']),` `080❇️ new IsInCurrency('EUR'),` `081❇️ new IsValidDiscountCode($discountCode->getCode(), $discountCode->getUsedLimit()),` `082❇️ ])` `083❇️ ->setTranslations([` `084❇️ new DiscountTranslationStruct('eng-GB', 'Discount name', 'This is a discount description', 'Promotion Label', 'Promotion Description'),` `085❇️ new DiscountTranslationStruct('ger-DE', 'Discount name (German)', 'Description (German)', 'Promotion Label (German)', 'Promotion Description (German)'),` `086❇️ ])` `087❇️ ->setEndDate(null) // Permanent discount` `088❇️ ->setCreatedAt($now)` `089❇️ ->setUpdatedAt($now)` `090❇️ ->setContext(new ArrayMap(['custom_context' => 'custom_value']));` `091❇️` `092❇️ $this->discountService->createDiscount($discountCreateStruct);` `093⫶` `094⫶ return Command::SUCCESS;` `095⫶ }` `096⫶}`	`062❇️ 10, // Global usage limit` `063❇️ null, // Unlimited usage per customer` `064❇️ $this->permissionResolver->getCurrentUserReference()->getUserId(),` `065❇️ $now` `066❇️ );` `067❇️ $discountCode = $this->discountCodeService->createDiscountCode($discountCodeCreateStruct);` `068⫶` `069❇️ $discountCreateStruct = new DiscountCreateStruct();` `070❇️ $discountCreateStruct` `071❇️ ->setIdentifier('discount_identifier')` `072❇️ ->setType(DiscountType::CART)` `073❇️ ->setPriority(10)` `074❇️ ->setEnabled(true)` `075❇️ ->setUser($this->userService->loadUserByLogin('admin'))` `076❇️ ->setRule(new FixedAmount(10))` `077❇️ ->setStartDate($now)` `078❇️ ->setConditions([` `079❇️ new IsInRegions(['germany', 'france']),` `080❇️ new IsProductInArray(['product-1', 'product-2']),` `081❇️ new IsInCurrency('EUR'),` `082❇️ new IsValidDiscountCode(` `083❇️ $discountCode->getCode(),` `084❇️ $discountCode->getGlobalLimit(),` `085❇️ $discountCode->getUsedLimit()` `086❇️ ),` `087❇️ ])` `088❇️ ->setTranslations([` `089❇️ new DiscountTranslationStruct('eng-GB', 'Discount name', 'This is a discount description', 'Promotion Label', 'Promotion Description'),` `090❇️ new DiscountTranslationStruct('ger-DE', 'Discount name (German)', 'Description (German)', 'Promotion Label (German)', 'Promotion Description (German)'),` `091❇️ ])` `092❇️ ->setEndDate(null) // Permanent discount` `093❇️ ->setCreatedAt($now)` `094❇️ ->setUpdatedAt($now)` `095❇️ ->setContext(new ArrayMap(['custom_context' => 'custom_value']));` `096❇️` `097❇️ $this->discountService->createDiscount($discountCreateStruct);` `098⫶` `099⫶ return Command::SUCCESS;` `100⫶ }` `101⫶}`

Download colorized diff

mnocon marked this pull request as ready for review July 2, 2025 15:55

mnocon added the Needs DEV review label Jul 3, 2025

mnocon requested review from konradoboza and Steveb-p July 3, 2025 07:18

konradoboza approved these changes Jul 3, 2025

View reviewed changes

code_samples/discounts/src/Command/ManageDiscountsCommand.php Outdated Show resolved Hide resolved

mnocon added Needs DOC review and removed Needs DEV review labels Jul 3, 2025

mnocon requested a review from a team July 3, 2025 07:48

ezrobot requested review from adriendupuis, dabrt and julitafalcondusza and removed request for a team July 3, 2025 07:48

mnocon added the Wait with merge PRs that shouldn't be merged instantly label Jul 3, 2025

adriendupuis reviewed Jul 3, 2025

View reviewed changes

mnocon force-pushed the discounts-4.6.22 branch 2 times, most recently from a13c8d7 to a35c98c Compare July 3, 2025 10:07

mnocon requested a review from adriendupuis July 3, 2025 10:07

adriendupuis reviewed Jul 9, 2025

View reviewed changes

mnocon mentioned this pull request Jul 10, 2025

[PHPStan] Regenerated baseline #2817

Merged

mnocon requested a review from adriendupuis July 10, 2025 08:14

mnocon and others added 8 commits July 24, 2025 14:31

Adjusted code samples

edb7b6d

[Discounts] Added doc for 4.6.22

6167893

Fixed limit mention

9dd8df4

Added update mention

4d3d3ab

Removed mentions of OverridePrioritatization

0a6fef7

Wording

e0f2cac

Update code_samples/discounts/src/Command/ManageDiscountsCommand.php

4aaaca2

Co-authored-by: Konrad Oboza <[email protected]>

Fixed highlights

7365811

mnocon added 2 commits July 24, 2025 14:31

Review suggestions

87fbf3e

Added missing v prefix

3386a3f

mnocon force-pushed the discounts-4.6.22 branch 2 times, most recently from ef9d2fc to 3386a3f Compare July 24, 2025 12:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Discounts 4.6.22 #2810

Discounts 4.6.22 #2810

Uh oh!

mnocon commented Jul 2, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mnocon commented Jul 3, 2025

Uh oh!

adriendupuis Jul 9, 2025

Uh oh!

mnocon Jul 10, 2025

Uh oh!

adriendupuis Jul 9, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 24, 2025

Uh oh!

Uh oh!

Discounts 4.6.22 #2810

Are you sure you want to change the base?

Discounts 4.6.22 #2810

Uh oh!

Conversation

mnocon commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Mention about the TODOs:

Uh oh!

github-actions bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preview of modified files

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mnocon commented Jul 3, 2025

Uh oh!

adriendupuis Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

mnocon Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

adriendupuis Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jul 24, 2025

code_samples/ change report

Uh oh!

Uh oh!

mnocon commented Jul 2, 2025 •

edited

Loading

github-actions bot commented Jul 2, 2025 •

edited

Loading